Fix AppImage not detecting YubiKey and add support for keepassxc-cli to AppImages #1100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phoerious
force-pushed
the
hotfix/issue-1034-appimage-yubikey
branch
from
484d2b9 to
7c55419
Compare
TheZ3ro
approved these changes
Oct 21, 2017
droidmonkey
approved these changes
Oct 21, 2017
phoerious
added a commit
that referenced
this pull request
Oct 21, 2017
- Fixed entries with empty URLs being reported to KeePassHTTP clients [#1031] - Fixed YubiKey detection and enabled CLI tool for AppImage binary [#1100] - Added AppStream description [#1082] - Improved TOTP compatibility and added new Base32 implementation [#1069] - Fixed error handling when processing invalid cipher stream [#1099] - Fixed double warning display when opening a database [#1037] - Fixed unlocking databases with --pw-stdin [#1087] - Added ability to override QT_PLUGIN_PATH environment variable for AppImages [#1079] - Fixed transform seed not being regenerated when saving the database [#1068] - Fixed only one YubiKey slot being polled [#1048] - Corrected an issue with entry icons while merging [#1008] - Corrected desktop and tray icons in Snap package [#1030] - Fixed screen lock and Google fallback settings [#1029]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #1034.
This patch migrates our Docker build system from Ubuntu 14.04 to CentOS, uses custom builds of libyubikey and libykpers-1 and adds the ability to call keepassxc-cli inside an AppImage by using a "cli" argument.
Motivation and context
Previous AppImage releases were unable to detect a plugged-in YubiKey and were also unable to directly start keepassxc-cli.
CentOS 7, whose first release was also in 2014 (like Ubuntu 14.04, only months later), is still supported until 2024 (while Ubuntu 14.04 will be EOL by 2019). In addition to that, we needed a lot of PPAs, because many packages were quite outdated, including Qt itself. The new Dockerfile reduces the number of non-official dependencies (at least when this issue is closed: bugzy/keepassxc-rpm-spec#6). With it comes a Qt downgrade to 5.6, but that is still newer than Trusty's 5.2.
I hope, we don't lose too much compatibility by using a slightly newer base system.
How has this been tested?
AppImage runs and detects my YubiKey. With the "cli" argument, it starts keepassxc-cli instead of keepassxc.
Types of changes
Checklist:
-DWITH_ASAN=ON. [REQUIRED]