Add AppStream info file and extend .desktop file #1082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheZ3ro
reviewed
Oct 17, 2017
share/linux/org.keepassxc.desktop
Outdated
| Icon=keepassxc | ||
| Categories=Utility;Security;Qt |
There was a problem hiding this comment.
Categories is repeated 2 times
phoerious
force-pushed
the
issue-1066-appstream
branch
from
8f6fe9a to
f510bc7
Compare
TheZ3ro
reviewed
Oct 18, 2017
| Icon=keepassxc | ||
| Terminal=false | ||
| Type=Application | ||
| Categories=Qt;Utility; | ||
| Version=1.0 |
There was a problem hiding this comment.
Why version is set to 1.0 instead of 2.2.1 ?
There was a problem hiding this comment.
It's the spec version, not the app version.
TheZ3ro
approved these changes
Oct 18, 2017
|
i will test against the snap build this evening. |
droidmonkey
approved these changes
Oct 19, 2017
phoerious
force-pushed
the
issue-1066-appstream
branch
from
f510bc7 to
a73b9e4
Compare
phoerious
added a commit
that referenced
this pull request
Oct 21, 2017
- Fixed entries with empty URLs being reported to KeePassHTTP clients [#1031] - Fixed YubiKey detection and enabled CLI tool for AppImage binary [#1100] - Added AppStream description [#1082] - Improved TOTP compatibility and added new Base32 implementation [#1069] - Fixed error handling when processing invalid cipher stream [#1099] - Fixed double warning display when opening a database [#1037] - Fixed unlocking databases with --pw-stdin [#1087] - Added ability to override QT_PLUGIN_PATH environment variable for AppImages [#1079] - Fixed transform seed not being regenerated when saving the database [#1068] - Fixed only one YubiKey slot being polled [#1048] - Corrected an issue with entry icons while merging [#1008] - Corrected desktop and tray icons in Snap package [#1030] - Fixed screen lock and Google fallback settings [#1029]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This patch resolves #1066 by adding an AppStream info file. It also extends the .desktop file with additional key/value pairs and changes its file name to match the specification.
Required pre-merge checks were added to the release-tool.
How has this been tested?
Merge checks have been tested to work properly.
Types of changes
Checklist:
-DWITH_ASAN=ON. [REQUIRED]