Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1077: allow overriding / extending QT_PLUGIN_PATH #1079

Merged
merged 5 commits into from
Oct 19, 2017

Conversation

phoerious
Copy link
Member

@phoerious phoerious commented Oct 16, 2017

Description

This patch resolves #1077 by allowing the user to extend the QT_PLUGIN_PATH environment variable with the contents of KPXC_QT_PLUGIN_PATH when starting the AppImage.

I also added the distribution type (AppImage / Snap) to the Debug Info screen on the About dialog.

Motivation and context

Users may want to load custom Qt plugins (which may crash KeePassXC, but may as well work).

Types of changes

  • ✅ Bug fix (non-breaking change which fixes an issue)
  • ✅ New feature (non-breaking change which adds functionality)

Checklist:

  • ✅ I have read the CONTRIBUTING document. [REQUIRED]
  • ✅ My code follows the code style of this project. [REQUIRED]
  • ✅ All new and existing tests passed. [REQUIRED]

@phoerious phoerious added this to the v2.2.2 milestone Oct 16, 2017
@phoerious phoerious requested a review from a team October 16, 2017 15:53
@phoerious phoerious changed the title Issue 1077 qt plugin path Issue 1077: allow overriding / extending QT_PLUGIN_PATH Oct 16, 2017
@phoerious phoerious force-pushed the issue-1077-qt-plugin-path branch 2 times, most recently from edec7dc to acb6300 Compare October 16, 2017 16:24
Copy link
Member

@droidmonkey droidmonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you forgot to change out where it uses the snap build define in filepath.cpp

@phoerious
Copy link
Member Author

@droidmonkey Good catch. Please check again.

Copy link
Member

@droidmonkey droidmonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested snap 👍

@phoerious phoerious force-pushed the issue-1077-qt-plugin-path branch from 6f26a49 to a8e63e2 Compare October 19, 2017 12:13
@phoerious phoerious merged commit ec8c99c into release/2.2.2 Oct 19, 2017
@phoerious phoerious deleted the issue-1077-qt-plugin-path branch October 19, 2017 13:52
phoerious added a commit that referenced this pull request Oct 21, 2017
- Fixed entries with empty URLs being reported to KeePassHTTP clients [#1031]
- Fixed YubiKey detection and enabled CLI tool for AppImage binary [#1100]
- Added AppStream description [#1082]
- Improved TOTP compatibility and added new Base32 implementation [#1069]
- Fixed error handling when processing invalid cipher stream [#1099]
- Fixed double warning display when opening a database [#1037]
- Fixed unlocking databases with --pw-stdin [#1087]
- Added ability to override QT_PLUGIN_PATH environment variable for AppImages [#1079]
- Fixed transform seed not being regenerated when saving the database [#1068]
- Fixed only one YubiKey slot being polled [#1048]
- Corrected an issue with entry icons while merging [#1008]
- Corrected desktop and tray icons in Snap package [#1030]
- Fixed screen lock and Google fallback settings [#1029]
@phoerious phoerious added pr: bugfix Pull request that fixes a bug and removed bug labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants