added autoopen functionality (#477)

[alterratz]

implementation of #477 autoopen

If a folder (within the root folder) is named "AutoOpen", all entries within this folder are opened automatically

password: the password of the "slave" database
url: the file name of the database which can be:
file:///absolute/path.kdbx
/absolute/path.kdbx
path.kbdx (which is relative to the current db)

Did not test it on windows or osx but since Qt file
functions have been used I suppose it will work fine.

Description

iterated over all items in the AutoOpen folder in updateTabNameFromDbWidgetSender which is called after a db is opened

also had to change a few lines in DatabaseTabWidget::openDatabase to set passwords for already open databases or ignore databases which have their password set already.

Motivation and context

implements feature request #477
I use dependent DBs a lot and manually opening them sucks

How has this been tested?

created a few (8) databases linked them to the master (4) and other "slave" DBs (4) using different url styles and loaded the master db as well as slave DBs
tried it with some of them opened before loading the master as well.

built it with following settings:
cmake -DWITH_XC_AUTOTYPE=ON -DWITH_XC_HTTP=ON -DWITH_XC_YUBIKEY=ON -DWITH_TESTS=ON -DWITH_ASAN=ON -DCMAKE_BUILD_TYPE=Release ..

Screenshots (if appropriate):

Types of changes

• ✅ New feature (non-breaking change which adds functionality)

Checklist:

• ✅ I have read the CONTRIBUTING document. [REQUIRED]
• ✅ My code follows the code style of this project. [REQUIRED]
• ✅ All new and existing tests passed. [REQUIRED]
• ✅ I have compiled and verified my code with -DWITH_ASAN=ON. [REQUIRED]
• ✅ TBD (when this is the only remaining obstacle for merging) My change requires a change to the documentation and I have updated it accordingly.

[droidmonkey]

Much better!

[TheZ3ro]

I would like some check on the file format since openDatabase assume it's a kdbx file

[phoerious]

I marked a bunch of minor things to fix.
Generally, this looks good otherwise, but I need to test it first and see if it works properly, also with auto-filled key file paths.

[phoerious]

Coding style: pointer operator belongs to type, opening brace on same line as if.

[phoerious]

Remove empty line here.

[phoerious]

Shouldn't this be file:// (with a double slash)?

[alterratz]

@TheZ3ro :
I am not sure what I shouls check. For instance if i look at main.cc there is also no checking on the command line arguments as they are directly fed to openDatabase.

        QString filename = args[ii];
        if (!filename.isEmpty() && QFile::exists(filename)) {
            QString password;
            if (parser.isSet(pwstdinOption)) {
                static QTextStream in(stdin, QIODevice::ReadOnly);
                password = in.readLine();
            }
            mainWindow.openDatabase(filename, password, parser.value(keyfileOption));
        }
    

[TheZ3ro]

@alterratz I mean a check on the file format, if I try to open a .txt file there is something wrong.
Anyway nevermind, the checks are already performed by

keepassxc/src/format/KeePass2Reader.cpp

Line 69 in 90468e8

raiseError(tr("Not a KeePass database."));

😉

[phoerious]

Please update your branch, so I can merge. Thanks!

[alterratz]

Updated it to current develop

[XA21X]

Finally got it working after realising from the code that "AutoOpen" is the name it's searching for. I must've missed the info about it being the same as KeeAutoExec... Got confused by the "autoload" in the description lol.

[hrehfeld]

Is this feature documented somewhere? ( https://duckduckgo.com/?q=keepassxc+auto+open )

[Emily7777]

How do we add a key file reference to the auto open vaults entries?

[droidmonkey]

Auto-open does not support key files

[hrehfeld]

Bug: auto open on a file that in turn auto-opens the first file gets into an endless loop. This will probably also work transitively.

[droidmonkey]

Don't do that