Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix macOS crash on Accent Color change #10348

Merged

Conversation

varjolintu
Copy link
Member

Similar to #8615, AppleInterfaceThemeChangedNotification should not be relied on. Theme change is already covered with the mentioned PR, and Accent Color change should not affect to KeePassXC at all.

Fixes #10347

Testing strategy

Manually.

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

@droidmonkey
Copy link
Member

That was introduced as part of the auto theme selection work based on light/dark Mac. If that still works after removal than good to go. I wonder if this setup some form of circular call when the highlight color was changed (infinite loop).

@varjolintu
Copy link
Member Author

That was introduced as part of the auto theme selection work based on light/dark Mac. If that still works after removal than good to go. I wonder if this setup some form of circular call when the highlight color was changed (infinite loop).

At least for me the theme change works on-the-fly as usual.

@droidmonkey droidmonkey merged commit 2086e4c into keepassxreboot:develop Mar 6, 2024
11 checks passed
@varjolintu varjolintu deleted the fix/macos_accent_color_change branch March 6, 2024 13:21
@droidmonkey droidmonkey added the pr: backported Pull request backported to previous release label Mar 8, 2024
@pepa65
Copy link

pepa65 commented Mar 10, 2024

No MacOS binary??

@varjolintu
Copy link
Member Author

No MacOS binary??

"NOTE: macOS and Linux binaries will be released on 3/10/24. Thank you for your patience."

@pepa65
Copy link

pepa65 commented Mar 10, 2024

Thank you for taking such great care with these releases!

libf-de pushed a commit to libf-de/keepassxc-secretservice-dbus that referenced this pull request Mar 11, 2024
Release 2.7.7

- Support USB Hotplug for Hardware Key interface [keepassxreboot#10092]
- Support 1PUX and Bitwarden import [keepassxreboot#9815]
- Browser: Add support for PassKeys [keepassxreboot#8825, keepassxreboot#9987, keepassxreboot#10318]
- Build System: Move to vcpkg manifest mode [keepassxreboot#10088]

- Fix multiple TOTP issues [keepassxreboot#9874]
- Fix focus loss on save when the editor is not visible anymore [keepassxreboot#10075]
- Fix visual when removing entry from history [keepassxreboot#9947]
- Fix first entry is not selected when a search is performed [keepassxreboot#9868]
- Prevent scrollbars on entry drag/drop [keepassxreboot#9747]
- Prevent duplicate characters in "Also choose from" field of password generator  [keepassxreboot#9803]
- Security: Prevent byte-by-byte and attachment inference side channel attacks [keepassxreboot#10266]
- Browser: Fix raising Update Entry messagebox [keepassxreboot#9853]
- Browser: Fix bugs when returning credentials [keepassxreboot#9136]
- Browser: Fix crash on database open from browser [keepassxreboot#9939]
- Browser: Fix support for referenced URL fields [keepassxreboot#8788]
- MacOS: Fix crash when changing highlight/accent color [keepassxreboot#10348]
- MacOS: Fix TouchID appearing even though lid is closed [keepassxreboot#10092]
- Windows: Fix terminating KeePassXC processes with MSI installer [keepassxreboot#9822]
- FdoSecrets: Fix database merge crash when enabled [keepassxreboot#10136]

# -----BEGIN PGP SIGNATURE-----
#
# iQEzBAABCAAdFiEENIkEDB8MPuq41ValRA/GXy4MbgEFAmXs7VsACgkQRA/GXy4M
# bgHLpwf/brnyPPs3gJxZmD2pn8542D4CCsDh0fTceurOtqCe3J4Y+Fftc5euuoQu
# 6rP4vJdd586l7JX5FnYIPXvGiU9op3MudJh+y+RN/PWwKcXNIXfUItMhpZEka49n
# xnw+Wvbilg1QIHSSmZdIjBpohnEkA67qhWauc3bCacrRyEvIOzVMTxnqDTe4GUDy
# CyauaRMMKezRTpLxSsk63TDAZZgDwK4ci5lC6ysHekc1Za6IbI3fMFjz1BGj+kPU
# tMHMfDCWqK/5JZ27ZWcxy7m8tJY9m3rb+MoCyFRQz9ixaEe29yf5NqYdm9sn1Dlh
# O7aFi7/EJtsBlXdguw5BcTPbsL7XEQ==
# =Cots
# -----END PGP SIGNATURE-----
# gpg: directory '/home/runner/.gnupg' created
# gpg: keybox '/home/runner/.gnupg/pubring.kbx' created
# gpg: Signature made Sat Mar  9 23:14:35 2024 UTC
# gpg:                using RSA key 3489040C1F0C3EEAB8D556A5440FC65F2E0C6E01
# gpg: Can't check signature: No public key
@phoerious phoerious added pr: bugfix Pull request that fixes a bug and removed bug labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: macOS pr: backported Pull request backported to previous release pr: bugfix Pull request that fixes a bug theme
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accent color change crashes KeePassXC with macOS Sonoma
4 participants