Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added snapd-xdg-open to snap to enable URL loading #1011

Merged
merged 1 commit into from
Sep 30, 2017

Conversation

droidmonkey
Copy link
Member

@droidmonkey droidmonkey commented Sep 29, 2017

Description

Fixes #905. Adds snapd-xdg-open program within the snap to allow for URL opening using the CTRL+U shortcut and right-click context menu entry.

I added a wiki page to document the snap gotchas.

How has this been tested?

Manually on Ubuntu 17.04

Types of changes

  • ✅ Bug fix (non-breaking change which fixes an issue)

Checklist:

  • ✅ I have read the CONTRIBUTING document. [REQUIRED]
  • ✅ My code follows the code style of this project. [REQUIRED]
  • ✅ All new and existing tests passed. [REQUIRED]
  • ✅ I have compiled and verified my code with -DWITH_ASAN=ON. [REQUIRED]
  • ✅ My change requires a change to the documentation and I have updated it accordingly.

@droidmonkey droidmonkey requested a review from TheZ3ro September 29, 2017 20:35
@droidmonkey droidmonkey added this to the v2.2.1 milestone Sep 29, 2017
@droidmonkey droidmonkey merged commit dce6911 into release/2.2.1 Sep 30, 2017
@droidmonkey droidmonkey deleted the hotfix/snap-url-open branch September 30, 2017 15:35
@droidmonkey droidmonkey restored the hotfix/snap-url-open branch October 1, 2017 15:04
droidmonkey added a commit that referenced this pull request Oct 1, 2017
- Corrected multiple snap issues [#934, #1011]
- Corrected multiple custom icon issues [#708, #719, #994]
- Corrected multiple Yubikey issues [#880]
- Fixed single instance preventing load on occasion [#997]
- Keep entry history when merging databases [#970]
- Prevent data loss if passwords were mismatched [#1007]
- Fixed crash after merge [#941]
- Added configurable auto-type default delay [#703]
- Unlock database dialog window comes to front [#663]
- Translation and compiling fixes
@droidmonkey droidmonkey deleted the hotfix/snap-url-open branch October 1, 2017 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants