Update src/CMakeLists.txt: Fix CPack Error when building with latest vcpkg #10098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added set(CPACK_COMPONENTS_ALL "") to prevent cmake from causing an XML fragments issue later on in CPack.
ultralapse
changed the title
ultralapse
changed the title
|
Thanks! Could you please test your change also with this branch: #10088 Don't forget to set |
|
@phoerious While testing this on the branch #10088, I noticed that even when specifying my vcpkg.cmake, it would still have to rebuild all dependencies in the build directory, rather than grabbing the already built ones from my vcpkg directory. Was this an intentional feature? |
|
Ideally, the already-installed binaries should just be copied over if the version dependencies match. EDIT: See here: https://learn.microsoft.com/en-gb/vcpkg/users/binarycaching |
|
@phoerious I just tested my change on the branch #10088 and building was successful 😊 |
droidmonkey
approved these changes
Dec 22, 2023
pull bot
pushed a commit
to tigerwill90/keepassxc
that referenced
this pull request
Dec 24, 2023
Added set(CPACK_COMPONENTS_ALL "") to prevent cmake from causing an XML fragments issue later on in CPack.
droidmonkey
pushed a commit
that referenced
this pull request
Jan 27, 2024
Added set(CPACK_COMPONENTS_ALL "") to prevent cmake from causing an XML fragments issue later on in CPack.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
set(CPACK_COMPONENTS_ALL "")to prevent cmake from adding the lineset(CPACK_COMPONENTS_ALL "Runtime;Unspecified")which will cause the error (CPack Error: Some XML patch fragments did not have matching IDs: 'CM_CP_KeePassXC.exe' ) later on. As mentioned by the linked issue, this is an error that happens when building with the latest version of vcpkg.Specifically we want to prevent the circled elements from being appended to the generated WiX XML files.
Fixes #10097
Type of change