Add vcpkg manifest with build dependencies #10088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phoerious
force-pushed
the
feature/vcpkg-manifest-build
branch
3 times, most recently
from
e2b74eb to
71043a5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #10088 +/- ##
===========================================
+ Coverage 64.67% 64.72% +0.05%
===========================================
Files 339 335 -4
Lines 41493 41133 -360
===========================================
- Hits 26832 26620 -212
+ Misses 14661 14513 -148 ☔ View full report in Codecov by Sentry. |
phoerious
force-pushed
the
feature/vcpkg-manifest-build
branch
from
44552cd to
031f7c7
Compare
louib
reviewed
Dec 9, 2023
phoerious
force-pushed
the
feature/vcpkg-manifest-build
branch
from
637738b to
af0e779
Compare
droidmonkey
force-pushed
the
feature/vcpkg-manifest-build
branch
from
af0e779 to
726aa87
Compare
droidmonkey
force-pushed
the
feature/vcpkg-manifest-build
branch
2 times, most recently
from
9b5eb53 to
2a1313c
Compare
phoerious
force-pushed
the
feature/vcpkg-manifest-build
branch
3 times, most recently
from
956e3d0 to
19752a6
Compare
Also bump minimum CMake release
phoerious
force-pushed
the
feature/vcpkg-manifest-build
branch
from
19752a6 to
305ad6d
Compare
droidmonkey
approved these changes
Mar 8, 2024
libf-de
pushed a commit
to libf-de/keepassxc-secretservice-dbus
that referenced
this pull request
Mar 11, 2024
Release 2.7.7 - Support USB Hotplug for Hardware Key interface [keepassxreboot#10092] - Support 1PUX and Bitwarden import [keepassxreboot#9815] - Browser: Add support for PassKeys [keepassxreboot#8825, keepassxreboot#9987, keepassxreboot#10318] - Build System: Move to vcpkg manifest mode [keepassxreboot#10088] - Fix multiple TOTP issues [keepassxreboot#9874] - Fix focus loss on save when the editor is not visible anymore [keepassxreboot#10075] - Fix visual when removing entry from history [keepassxreboot#9947] - Fix first entry is not selected when a search is performed [keepassxreboot#9868] - Prevent scrollbars on entry drag/drop [keepassxreboot#9747] - Prevent duplicate characters in "Also choose from" field of password generator [keepassxreboot#9803] - Security: Prevent byte-by-byte and attachment inference side channel attacks [keepassxreboot#10266] - Browser: Fix raising Update Entry messagebox [keepassxreboot#9853] - Browser: Fix bugs when returning credentials [keepassxreboot#9136] - Browser: Fix crash on database open from browser [keepassxreboot#9939] - Browser: Fix support for referenced URL fields [keepassxreboot#8788] - MacOS: Fix crash when changing highlight/accent color [keepassxreboot#10348] - MacOS: Fix TouchID appearing even though lid is closed [keepassxreboot#10092] - Windows: Fix terminating KeePassXC processes with MSI installer [keepassxreboot#9822] - FdoSecrets: Fix database merge crash when enabled [keepassxreboot#10136] # -----BEGIN PGP SIGNATURE----- # # iQEzBAABCAAdFiEENIkEDB8MPuq41ValRA/GXy4MbgEFAmXs7VsACgkQRA/GXy4M # bgHLpwf/brnyPPs3gJxZmD2pn8542D4CCsDh0fTceurOtqCe3J4Y+Fftc5euuoQu # 6rP4vJdd586l7JX5FnYIPXvGiU9op3MudJh+y+RN/PWwKcXNIXfUItMhpZEka49n # xnw+Wvbilg1QIHSSmZdIjBpohnEkA67qhWauc3bCacrRyEvIOzVMTxnqDTe4GUDy # CyauaRMMKezRTpLxSsk63TDAZZgDwK4ci5lC6ysHekc1Za6IbI3fMFjz1BGj+kPU # tMHMfDCWqK/5JZ27ZWcxy7m8tJY9m3rb+MoCyFRQz9ixaEe29yf5NqYdm9sn1Dlh # O7aFi7/EJtsBlXdguw5BcTPbsL7XEQ== # =Cots # -----END PGP SIGNATURE----- # gpg: directory '/home/runner/.gnupg' created # gpg: keybox '/home/runner/.gnupg/pubring.kbx' created # gpg: Signature made Sat Mar 9 23:14:35 2024 UTC # gpg: using RSA key 3489040C1F0C3EEAB8D556A5440FC65F2E0C6E01 # gpg: Can't check signature: No public key
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a vcpkg manifest, so all dependencies can now be installed automatically by running
I also bumped the minimum CMake version to 3.10, which is what Ubuntu Bionic has. This gets rid of a deprecation warning and I have no idea whether our CMake files are still compatible with 3.3 anyway.
I further added vcpkg overlay triplets that skip building all packages also in debug mode (and build dynamic instead of static libs on macOS).
Testing strategy
Works on macOS. Please test on Windows @droidmonkey. I also added all the Linux packages that are available on vcpkg, but I suppose we cannot fully replace installing *-dev packages globally yet.
Type of change