Check for mismatched passwords BEFORE saving to prevent data loss #1007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louib
reviewed
Sep 29, 2017
| if (!passwordsEqual()) { | ||
| showMessage(tr("Different passwords supplied."), MessageWidget::Error); | ||
| return; | ||
| } |
There was a problem hiding this comment.
@droidmonkey do you think you can add a test to TestGui::testEditEntry() for that?
There was a problem hiding this comment.
@louib ready for you
louib
approved these changes
Sep 29, 2017
droidmonkey
added a commit
that referenced
this pull request
Oct 1, 2017
- Corrected multiple snap issues [#934, #1011] - Corrected multiple custom icon issues [#708, #719, #994] - Corrected multiple Yubikey issues [#880] - Fixed single instance preventing load on occasion [#997] - Keep entry history when merging databases [#970] - Prevent data loss if passwords were mismatched [#1007] - Fixed crash after merge [#941] - Added configurable auto-type default delay [#703] - Unlock database dialog window comes to front [#663] - Translation and compiling fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #909. Password fields are checked prior to saving to prevent data loss.
Note: Code is repeated due to the way the apply button works (directly calls the save function). This should be refactored in the future.
How has this been tested?
Manually and unit tests.
Types of changes
Checklist:
-DWITH_ASAN=ON. [REQUIRED]