Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First entry is not selected when a search is performed #9865

Closed
Colfenor opened this issue Sep 21, 2023 · 1 comment · Fixed by #9868
Closed

First entry is not selected when a search is performed #9865

Colfenor opened this issue Sep 21, 2023 · 1 comment · Fixed by #9868

Comments

@Colfenor
Copy link
Contributor

Colfenor commented Sep 21, 2023

Overview

When searching for a database entry in keepassxc, it is not intuitive why and which entry is set active. This default behaviour is also not yet documented in the user guide.

On inspection of the code base, I found the logic of setting an entry active here and it seems to have to do with entries being associated to a Group.

The function EntryView::setFirstEntryActive() implies that a "first" entry is set active, however I would understand, "first" as in the first entry in a entire list for instance.

Steps to Reproduce

  1. open a populated .kdbx database with entries associated to root and child groups
  2. search for a desired entry where multiple entries are returned as a list
  3. observe which entry is set active visible to the user by a light green entry coloration in the GUI

Expected Behavior

The first entry in the list is set active

Actual Behavior

An entry of a child group gets selected as the one which is set active

Context

I realized this behaviour, when having a heavly populated .kdbx database and searching that somehow a child child group entry is set active where I needed to scroll down quite some time in the returned list to actually see which one it was.

Example

keepassxc-search

KeePassXC - Version 2.8.0-snapshot
Revision: 27c5c5d

Operating System: Linux
Desktop Env: Gnome/
Windowing System: X11

@Colfenor Colfenor added the bug label Sep 21, 2023
@droidmonkey
Copy link
Member

Oh geez that is a bug and also present in 2.7.6.

@droidmonkey droidmonkey self-assigned this Sep 21, 2023
@droidmonkey droidmonkey added this to the v2.8.0 milestone Sep 21, 2023
@droidmonkey droidmonkey changed the title Unexpected default behaviour of how a searched Entry is set active First entry is not selected when a search is performed Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants