Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert colourful tray icon on Windows - 2.7.5 #9432

Closed
jonathanlermitage opened this issue May 16, 2023 · 4 comments · Fixed by #9632
Closed

Revert colourful tray icon on Windows - 2.7.5 #9432

jonathanlermitage opened this issue May 16, 2023 · 4 comments · Fixed by #9632
Assignees
Milestone

Comments

@jonathanlermitage
Copy link

Summary

On Windows 10, with a 125% UI scale, KeePassXC 2.7.5 updated the colourful tray icon (for locked and unlocked database). It is now a bit smaller, and a bit blurry, even after a computer restart. The monochrome tray icon did not change, and this one seems OK.
I reinstalled KeePassXC 2.7.4, and the colourful tray icon has a better dimension. I don't know if you have similar feeling about that...

Examples

The 2.7.5 colourful tray icon:
image

The 2.7.4 colourful tray icon which, for me, seems better:
image

Regards,

@jonathanlermitage jonathanlermitage changed the title Revert colourful tray icon on Windows - 2.7.4 Revert colourful tray icon on Windows - 2.7.5 May 16, 2023
@phoerious
Copy link
Member

Doesn't really look any blurrier to me. Just a bit lighter.

@droidmonkey
Copy link
Member

I think the blur is more noticeable

@phoerious
Copy link
Member

That's more of a contrast issue.

@koitsu
Copy link

koitsu commented Jun 8, 2023

It (2.7.5) looks highly anti-aliased, the white border/edge around the lock symbol being completely removed, a gradient added to the background behind the key icon, and shading being added around the edges of the key to give it depth. These icons seem to be SVGs, based on a quick source review.

To confirm my statements and the OPs statements, refer to the actual diff of the icons themselves since they're SVGs. Search the page for share/icons/application/scalable/apps/keepassxc-locked.svg and you'll see a side-by-side comparison (deleted=2.7.4, added=2.7.5).

I don't know why the aspect ratio looks skewed (in the OP's screenshot), so there may be something amiss with the SVG data itself.

That said, I agree that the 2.7.4 icon looks better in general. SVG scaling never looks particularly good, especially when scaled to a small size (like tray icons). You are literally better off having a pixel artist draw your tray icons, else keep the icons extremely simple. Yes, high-res versions look great, but not until you scale them down do you notice usability/visibility problems.

@droidmonkey droidmonkey added this to the v2.7.6 milestone Jun 8, 2023
droidmonkey added a commit that referenced this issue Jul 16, 2023
droidmonkey added a commit that referenced this issue Aug 10, 2023
droidmonkey added a commit that referenced this issue Aug 12, 2023
droidmonkey added a commit that referenced this issue Aug 15, 2023
* Fix #9432
* Simplify tray icon selection code
* Update all icons with latest export
* Fix MIME type icon appearance on KDE
---------
Co-authored-by: Janek Bevendorff <[email protected]>
droidmonkey added a commit that referenced this issue Aug 15, 2023
* Fix #9432
* Simplify tray icon selection code
* Update all icons with latest export
* Fix MIME type icon appearance on KDE
---------
Co-authored-by: Janek Bevendorff <[email protected]>
evur pushed a commit to BrokenMS/keepassxc that referenced this issue Aug 23, 2023
* Fix keepassxreboot#9432
* Simplify tray icon selection code
* Update all icons with latest export
* Fix MIME type icon appearance on KDE
---------
Co-authored-by: Janek Bevendorff <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants