Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure autosave delay per database #8553

Closed
spotlesscoder opened this issue Oct 7, 2022 · 2 comments · Fixed by #9100
Closed

Configure autosave delay per database #8553

spotlesscoder opened this issue Oct 7, 2022 · 2 comments · Fixed by #9100
Assignees
Labels

Comments

@spotlesscoder
Copy link

Summary

I want a per-database file setting on how long the application should wait before committing confirmed changes into the database file on disk.

E.g. I want to set a timeout of up to 5 minutes so that I can make multiple edits but the changes are saved only 5 minutes after the last edit or when I force saving by pressing CTRL + S

Examples

Context

When performing multiple edits in a row, especially with larger databases, the saving after clicking OK in the detail view, the saving takes quite a lot of time

@droidmonkey droidmonkey changed the title Feature Request: allow to configure autosave delay after edit of entry per database Configure autosave delay per database Oct 7, 2022
@droidmonkey droidmonkey added the ux label Oct 7, 2022
@jNullj
Copy link
Contributor

jNullj commented Feb 8, 2023

Can i get assigned to do that? I would love to try.
I belive there is no risk in making this setting part of the metadata and i think it will best fit in General window of the database settings - under the "Additional database settings".
@CodingSpiderFox Wouldn't it be better to save after X minutes since the first change that triggers the timer to avoid data loss? Sure it will lag once in a while to save but you will have more control over the level of risk regarding losing information. That way you still get "forced" into saving once in a while. If i implement the timeout since the last edit there might pass a long time between edits. Altho i agree its nicer to get the app to lag on save only after a few min it is not in use.

@droidmonkey
Copy link
Member

Yes please do try this

jNullj added a commit to jNullj/keepassxc-fetures-n-fixes that referenced this issue Feb 10, 2023
Add a new propery autosaveDelay in Metadata of the db.
The propery sets delay to wait since last modification before saving.

Part of issue keepassxreboot#8553
jNullj added a commit to jNullj/keepassxc-fetures-n-fixes that referenced this issue Feb 10, 2023
Add metadata propery autosaveDelay to the gui in the DatabaseSettings widget under General.
User can change the delay in minutes.

Part of issue keepassxreboot#8553
jNullj added a commit to jNullj/keepassxc-fetures-n-fixes that referenced this issue Feb 10, 2023
Implement a autosave delay functionality to the database widget.
Added timer to track the delay and trigger a save on timeout using the new onAutosaveDelayTimeout function.
Changed the onDatabaseModified to test for the new autosaveDelay property and delay the save if needed or extend the delay on new modifications.

Part of issue keepassxreboot#8553
jNullj added a commit to jNullj/keepassxc-fetures-n-fixes that referenced this issue Feb 10, 2023
Try to toggle in gui, set a value, save it.
Chcek value saved is currect in metadata.
Check that on loading saved value presented in gui and toggeled.

Part of issue keepassxreboot#8553
jNullj added a commit to jNullj/keepassxc-fetures-n-fixes that referenced this issue Feb 10, 2023
Test autosaveDelay makes delays as expected.
Test delay timer reset after new modification before timeout.

Part of issue keepassxreboot#8553
jNullj added a commit to jNullj/keepassxc-fetures-n-fixes that referenced this issue Feb 18, 2023
Add a new propery autosaveDelay in Metadata of the db.
The property is saved in customData to do not affect database structure as this setting is unique to keepasxc.
The propery sets delay to wait since last modification before saving.

Part of issue keepassxreboot#8553
jNullj added a commit to jNullj/keepassxc-fetures-n-fixes that referenced this issue Feb 18, 2023
Add metadata propery autosaveDelay to the gui in the DatabaseSettings widget under General.
User can change the delay in minutes.
Add new translation strings as well.

Part of issue keepassxreboot#8553
jNullj added a commit to jNullj/keepassxc-fetures-n-fixes that referenced this issue Feb 18, 2023
Implement a autosave delay functionality to the database widget.
Added timer to track the delay and trigger a save on timeout using the new onAutosaveDelayTimeout function.
Changed the onDatabaseModified to test for the new autosaveDelay property and delay the save if needed or extend the delay on new modifications.
After menual save stop the timer to avoid saving when not needed edited in DatabaseWidget::save().

Part of issue keepassxreboot#8553
jNullj added a commit to jNullj/keepassxc-fetures-n-fixes that referenced this issue Feb 18, 2023
Try to toggle in gui, set a value, save it.
Chcek value saved is currect in metadata.
Check that on loading saved value presented in gui and toggeled.

Part of issue keepassxreboot#8553
jNullj added a commit to jNullj/keepassxc-fetures-n-fixes that referenced this issue Feb 18, 2023
Test autosaveDelay makes delays as expected.
Test delay timer reset after new modification before timeout.

Part of issue keepassxreboot#8553
jNullj added a commit to jNullj/keepassxc-fetures-n-fixes that referenced this issue Feb 19, 2023
Add a new propery autosaveDelay in Metadata of the db.
The property is saved in customData to do not affect database structure as this setting is unique to keepasxc.
The propery sets delay to wait since last modification before saving.

Part of issue keepassxreboot#8553
jNullj added a commit to jNullj/keepassxc-fetures-n-fixes that referenced this issue Feb 19, 2023
Add metadata propery autosaveDelay to the gui in the DatabaseSettings widget under General.
User can change the delay in minutes.
Add new translation strings as well.

Part of issue keepassxreboot#8553
jNullj added a commit to jNullj/keepassxc-fetures-n-fixes that referenced this issue Feb 19, 2023
Implement a autosave delay functionality to the database widget.
Added timer to track the delay and trigger a save on timeout using the new onAutosaveDelayTimeout function.
Changed the onDatabaseModified to test for the new autosaveDelay property and delay the save if needed or extend the delay on new modifications.
After menual save stop the timer to avoid saving when not needed edited in DatabaseWidget::save().

Part of issue keepassxreboot#8553
jNullj added a commit to jNullj/keepassxc-fetures-n-fixes that referenced this issue Feb 19, 2023
Try to toggle in gui, set a value, save it.
Chcek value saved is currect in metadata.
Check that on loading saved value presented in gui and toggeled.

Part of issue keepassxreboot#8553
jNullj added a commit to jNullj/keepassxc-fetures-n-fixes that referenced this issue Feb 19, 2023
Test autosaveDelay makes delays as expected.
Test delay timer reset after new modification before timeout.

Part of issue keepassxreboot#8553
jNullj added a commit to jNullj/keepassxc-fetures-n-fixes that referenced this issue Feb 20, 2023
Try to toggle in gui, set a value, save it.
Chcek value saved is currect in metadata.
Check that on loading saved value presented in gui and toggeled.

Part of issue keepassxreboot#8553
jNullj added a commit to jNullj/keepassxc-fetures-n-fixes that referenced this issue Feb 20, 2023
Test autosaveDelay makes delays as expected.
Test delay timer reset after new modification before timeout.

Part of issue keepassxreboot#8553
jNullj added a commit to jNullj/keepassxc-fetures-n-fixes that referenced this issue Feb 23, 2023
Add a new propery autosaveDelay in Metadata of the db.
The property is saved in customData to do not affect database structure as this setting is unique to keepasxc.
The propery sets delay to wait since last modification before saving.

Part of issue keepassxreboot#8553
jNullj added a commit to jNullj/keepassxc-fetures-n-fixes that referenced this issue Feb 23, 2023
Add metadata propery autosaveDelay to the gui in the DatabaseSettings widget under General.
User can change the delay in minutes.
Add new translation strings as well.

Part of issue keepassxreboot#8553
jNullj added a commit to jNullj/keepassxc-fetures-n-fixes that referenced this issue Feb 23, 2023
Implement a autosave delay functionality to the database widget.
Added timer to track the delay and trigger a save on timeout using the new onAutosaveDelayTimeout function.
Changed the onDatabaseModified to test for the new autosaveDelay property and delay the save if needed or extend the delay on new modifications.
After menual save stop the timer to avoid saving when not needed edited in DatabaseWidget::save().

Part of issue keepassxreboot#8553
jNullj added a commit to jNullj/keepassxc-fetures-n-fixes that referenced this issue Feb 23, 2023
Try to toggle in gui, set a value, save it.
Chcek value saved is currect in metadata.
Check that on loading saved value presented in gui and toggeled.

Part of issue keepassxreboot#8553
jNullj added a commit to jNullj/keepassxc-fetures-n-fixes that referenced this issue Feb 23, 2023
Test autosaveDelay makes delays as expected.
Test delay timer reset after new modification before timeout.

Part of issue keepassxreboot#8553
jNullj added a commit to jNullj/keepassxc-fetures-n-fixes that referenced this issue Feb 27, 2023
Add a new propery autosaveDelay in Metadata of the db.
The property is saved in customData to do not affect database structure as this setting is unique to keepasxc.
The propery sets delay to wait since last modification before saving.

Part of issue keepassxreboot#8553
jNullj added a commit to jNullj/keepassxc-fetures-n-fixes that referenced this issue Apr 8, 2023
Add metadata propery autosaveDelay to the gui in the DatabaseSettings widget under General.
User can change the delay in minutes.
Add new translation strings as well.

Part of issue keepassxreboot#8553
jNullj added a commit to jNullj/keepassxc-fetures-n-fixes that referenced this issue Apr 8, 2023
Implement a autosave delay functionality to the database widget.
Added timer to track the delay and trigger a save on timeout using the new onAutosaveDelayTimeout function.
Changed the onDatabaseModified to test for the new autosaveDelay property and delay the save if needed or extend the delay on new modifications.
After menual save stop the timer to avoid saving when not needed edited in DatabaseWidget::save().

Part of issue keepassxreboot#8553
jNullj added a commit to jNullj/keepassxc-fetures-n-fixes that referenced this issue Apr 8, 2023
Try to toggle in gui, set a value, save it.
Chcek value saved is currect in metadata.
Check that on loading saved value presented in gui and toggeled.

Part of issue keepassxreboot#8553
jNullj added a commit to jNullj/keepassxc-fetures-n-fixes that referenced this issue Apr 8, 2023
Test autosaveDelay makes delays as expected.
Test delay timer reset after new modification before timeout.

Part of issue keepassxreboot#8553
jNullj added a commit to jNullj/keepassxc-fetures-n-fixes that referenced this issue Apr 27, 2023
Add a new propery autosaveDelay in Metadata of the db.
The property is saved in customData to do not affect database structure as this setting is unique to keepasxc.
The propery sets delay to wait since last modification before saving.

Part of issue keepassxreboot#8553
jNullj added a commit to jNullj/keepassxc-fetures-n-fixes that referenced this issue Apr 27, 2023
Add metadata propery autosaveDelay to the gui in the DatabaseSettings widget under General.
User can change the delay in minutes.
Add new translation strings as well.

Part of issue keepassxreboot#8553
jNullj added a commit to jNullj/keepassxc-fetures-n-fixes that referenced this issue Apr 27, 2023
Implement a autosave delay functionality to the database widget.
Added timer to track the delay and trigger a save on timeout using the new onAutosaveDelayTimeout function.
Changed the onDatabaseModified to test for the new autosaveDelay property and delay the save if needed or extend the delay on new modifications.
After menual save stop the timer to avoid saving when not needed edited in DatabaseWidget::save().

Part of issue keepassxreboot#8553
jNullj added a commit to jNullj/keepassxc-fetures-n-fixes that referenced this issue Apr 27, 2023
Try to toggle in gui, set a value, save it.
Chcek value saved is currect in metadata.
Check that on loading saved value presented in gui and toggeled.

Part of issue keepassxreboot#8553
jNullj added a commit to jNullj/keepassxc-fetures-n-fixes that referenced this issue Apr 27, 2023
Test autosaveDelay makes delays as expected.
Test delay timer reset after new modification before timeout.

Part of issue keepassxreboot#8553
jNullj added a commit to jNullj/keepassxc-fetures-n-fixes that referenced this issue May 20, 2023
Add a new propery autosaveDelay in Metadata of the db.
The property is saved in customData to do not affect database structure as this setting is unique to keepasxc.
The propery sets delay to wait since last modification before saving.

Part of issue keepassxreboot#8553
jNullj added a commit to jNullj/keepassxc-fetures-n-fixes that referenced this issue May 20, 2023
Add metadata propery autosaveDelay to the gui in the DatabaseSettings widget under General.
User can change the delay in minutes.
Add new translation strings as well.

Part of issue keepassxreboot#8553
jNullj added a commit to jNullj/keepassxc-fetures-n-fixes that referenced this issue May 20, 2023
Implement a autosave delay functionality to the database widget.
Added timer to track the delay and trigger a save on timeout using the new onAutosaveDelayTimeout function.
Changed the onDatabaseModified to test for the new autosaveDelay property and delay the save if needed or extend the delay on new modifications.
After menual save stop the timer to avoid saving when not needed edited in DatabaseWidget::save().

Part of issue keepassxreboot#8553
jNullj added a commit to jNullj/keepassxc-fetures-n-fixes that referenced this issue May 20, 2023
Try to toggle in gui, set a value, save it.
Chcek value saved is currect in metadata.
Check that on loading saved value presented in gui and toggeled.

Part of issue keepassxreboot#8553
jNullj added a commit to jNullj/keepassxc-fetures-n-fixes that referenced this issue May 20, 2023
Test autosaveDelay makes delays as expected.
Test delay timer reset after new modification before timeout.

Part of issue keepassxreboot#8553
jNullj added a commit to jNullj/keepassxc-fetures-n-fixes that referenced this issue May 29, 2023
Add a new propery autosaveDelay in Metadata of the db.
The property is saved in customData to do not affect database structure as this setting is unique to keepasxc.
The propery sets delay to wait since last modification before saving.

Part of issue keepassxreboot#8553
jNullj added a commit to jNullj/keepassxc-fetures-n-fixes that referenced this issue May 29, 2023
Add metadata propery autosaveDelay to the gui in the DatabaseSettings widget under General.
User can change the delay in minutes.
Add new translation strings as well.

Part of issue keepassxreboot#8553
jNullj added a commit to jNullj/keepassxc-fetures-n-fixes that referenced this issue May 29, 2023
Implement a autosave delay functionality to the database widget.
Added timer to track the delay and trigger a save on timeout using the new onAutosaveDelayTimeout function.
Changed the onDatabaseModified to test for the new autosaveDelay property and delay the save if needed or extend the delay on new modifications.
After menual save stop the timer to avoid saving when not needed edited in DatabaseWidget::save().

Part of issue keepassxreboot#8553
jNullj added a commit to jNullj/keepassxc-fetures-n-fixes that referenced this issue May 29, 2023
Try to toggle in gui, set a value, save it.
Chcek value saved is currect in metadata.
Check that on loading saved value presented in gui and toggeled.

Part of issue keepassxreboot#8553
jNullj added a commit to jNullj/keepassxc-fetures-n-fixes that referenced this issue May 29, 2023
Test autosaveDelay makes delays as expected.
Test delay timer reset after new modification before timeout.

Part of issue keepassxreboot#8553
jNullj added a commit to jNullj/keepassxc-fetures-n-fixes that referenced this issue Jul 1, 2023
Add a new propery autosaveDelay in Metadata of the db.
The property is saved in customData to do not affect database structure as this setting is unique to keepasxc.
The propery sets delay to wait since last modification before saving.

Part of issue keepassxreboot#8553
jNullj added a commit to jNullj/keepassxc-fetures-n-fixes that referenced this issue Jul 1, 2023
Add metadata propery autosaveDelay to the gui in the DatabaseSettings widget under General.
User can change the delay in minutes.
Add new translation strings as well.

Part of issue keepassxreboot#8553
jNullj added a commit to jNullj/keepassxc-fetures-n-fixes that referenced this issue Jul 1, 2023
Implement a autosave delay functionality to the database widget.
Added timer to track the delay and trigger a save on timeout using the new onAutosaveDelayTimeout function.
Changed the onDatabaseModified to test for the new autosaveDelay property and delay the save if needed or extend the delay on new modifications.
After menual save stop the timer to avoid saving when not needed edited in DatabaseWidget::save().

Part of issue keepassxreboot#8553
jNullj added a commit to jNullj/keepassxc-fetures-n-fixes that referenced this issue Jul 1, 2023
Try to toggle in gui, set a value, save it.
Chcek value saved is currect in metadata.
Check that on loading saved value presented in gui and toggeled.

Part of issue keepassxreboot#8553
jNullj added a commit to jNullj/keepassxc-fetures-n-fixes that referenced this issue Jul 1, 2023
Test autosaveDelay makes delays as expected.
Test delay timer reset after new modification before timeout.

Part of issue keepassxreboot#8553
jNullj added a commit to jNullj/keepassxc-fetures-n-fixes that referenced this issue Jul 6, 2023
Add a new propery autosaveDelay in Metadata of the db.
The property is saved in customData to do not affect database structure as this setting is unique to keepasxc.
The propery sets delay to wait since last modification before saving.

Part of issue keepassxreboot#8553
jNullj added a commit to jNullj/keepassxc-fetures-n-fixes that referenced this issue Jul 6, 2023
Add metadata propery autosaveDelay to the gui in the DatabaseSettings widget under General.
User can change the delay in minutes.
Add new translation strings as well.

Part of issue keepassxreboot#8553
jNullj added a commit to jNullj/keepassxc-fetures-n-fixes that referenced this issue Jul 6, 2023
Implement a autosave delay functionality to the database widget.
Added timer to track the delay and trigger a save on timeout using the new onAutosaveDelayTimeout function.
Changed the onDatabaseModified to test for the new autosaveDelay property and delay the save if needed or extend the delay on new modifications.
After menual save stop the timer to avoid saving when not needed edited in DatabaseWidget::save().

Part of issue keepassxreboot#8553
jNullj added a commit to jNullj/keepassxc-fetures-n-fixes that referenced this issue Jul 6, 2023
Try to toggle in gui, set a value, save it.
Chcek value saved is currect in metadata.
Check that on loading saved value presented in gui and toggeled.

Part of issue keepassxreboot#8553
jNullj added a commit to jNullj/keepassxc-fetures-n-fixes that referenced this issue Jul 6, 2023
Test autosaveDelay makes delays as expected.
Test delay timer reset after new modification before timeout.

Part of issue keepassxreboot#8553
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants