Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot copy attribute values from entry preview #7949

Closed
shailen001 opened this issue Apr 25, 2022 · 2 comments · Fixed by #7993
Closed

Cannot copy attribute values from entry preview #7949

shailen001 opened this issue Apr 25, 2022 · 2 comments · Fixed by #7993
Assignees
@droidmonkey
Labels
bug user interface
Milestone
v2.7.2

Comments

@shailen001
Copy link

shailen001 commented Apr 25, 2022 •
edited
Loading

Overview

Previous versions had ability to highlight, and so to copy with mouse, the attributes in Advanced tab in Preview Panel. Now no text can be selected with a simple double mouse click and Ctrl-C. Have to right click on entry, Copy Attribute, and drill down menu. Much slower, much harder to follow across menus.

Steps to Reproduce

  1. Create entry with Advanced attributes, save and close.
  2. Go to entry, and Advanced tab inside Preview Panel.
  3. Try and highlight any attributes. Not possible.

Expected Behavior

Should be able to select text with mouse cursor as before in Preview Panel.

Actual Behavior

Cannot highlight/select any text in Preview Panel.

Context

KeePassXC - 2.7.0
Revision: d7a9ef4

Operating System: Linux
Desktop Env: XFCE
Windowing System: X1
example_keepass_cannot_highlight_text
1
@shailen001 shailen001 added the bug label Apr 25, 2022
@droidmonkey droidmonkey self-assigned this Apr 26, 2022
@droidmonkey droidmonkey added this to the v2.7.2 milestone Apr 26, 2022
@droidmonkey droidmonkey changed the title lost ability to highlight test Cannot copy attribute values from entry preview Apr 26, 2022
@shailen001
Copy link
Author

So doubling clicking on text copies it anyway (what I wanted). Before it would highlight it, so I didn't know it did this.

Thanks for clarifying.

@droidmonkey
Copy link
Member

droidmonkey commented Apr 26, 2022 •
edited
Loading

There is a bug though that I just fixed, the connection gets duplicated every time the preview pane is loaded with data. This causes a denial of service effectually if you double click a value

droidmonkey added a commit that referenced this issue May 1, 2022
@droidmonkey
Improve entry preview panel
b272c08 
* Fix #7811 - Notes height no longer truncated
* Fix #7949 - Improve copying attribute value to clipboard in entry preview
* Fix #7898 - Prevent copying url when copy password selected after clicking url in preview pane
* Fix #7982 - Double clicking hidden attributes in preview pane copies the value instead of ●●●●●●
@droidmonkey droidmonkey mentioned this issue May 1, 2022
Merged
droidmonkey added a commit that referenced this issue May 1, 2022
@droidmonkey
Improve entry preview panel
d575cea 
* Fix #7811 - Notes height no longer truncated
* Fix #7949 - Improve copying attribute value to clipboard in entry preview
* Fix #7898 - Prevent copying url when copy password selected after clicking url in preview pane
* Fix #7982 - Double clicking hidden attributes in preview pane copies the value instead of ●●●●●●
droidmonkey added a commit that referenced this issue May 31, 2022
@droidmonkey
Improve entry preview panel
e72c601 
* Fix #7811 - Notes height no longer truncated
* Fix #7949 - Improve copying attribute value to clipboard in entry preview
* Fix #7898 - Prevent copying url when copy password selected after clicking url in preview pane
* Fix #7982 - Double clicking hidden attributes in preview pane copies the value instead of ●●●●●●
droidmonkey added a commit that referenced this issue Jun 6, 2022
@droidmonkey
Improve entry preview panel
b1f4e12 
* Fix #7811 - Notes height no longer truncated
* Fix #7949 - Improve copying attribute value to clipboard in entry preview
* Fix #7898 - Prevent copying url when copy password selected after clicking url in preview pane
* Fix #7982 - Double clicking hidden attributes in preview pane copies the value instead of ●●●●●●
droidmonkey added a commit that referenced this issue Jun 27, 2022
@droidmonkey
Improve entry preview panel
af2ceb6 
* Fix #7811 - Notes height no longer truncated
* Fix #7949 - Improve copying attribute value to clipboard in entry preview
* Fix #7898 - Prevent copying url when copy password selected after clicking url in preview pane
* Fix #7982 - Double clicking hidden attributes in preview pane copies the value instead of ●●●●●●
t-h-e pushed a commit to t-h-e/keepassxc that referenced this issue Sep 8, 2022
@droidmonkey @t-h-e
Improve entry preview panel
cc01a7d 
* Fix keepassxreboot#7811 - Notes height no longer truncated
* Fix keepassxreboot#7949 - Improve copying attribute value to clipboard in entry preview
* Fix keepassxreboot#7898 - Prevent copying url when copy password selected after clicking url in preview pane
* Fix keepassxreboot#7982 - Double clicking hidden attributes in preview pane copies the value instead of ●●●●●●
droidmonkey added a commit that referenced this issue Sep 22, 2022
@droidmonkey
Improve entry preview panel
8190b20 
* Fix #7811 - Notes height no longer truncated
* Fix #7949 - Improve copying attribute value to clipboard in entry preview
* Fix #7898 - Prevent copying url when copy password selected after clicking url in preview pane
* Fix #7982 - Double clicking hidden attributes in preview pane copies the value instead of ●●●●●●
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@droidmonkey droidmonkey

Labels
bug user interface
Projects
None yet
Milestone
v2.7.2
Development

Successfully merging a pull request may close this issue.

Improve entry preview panel keepassxreboot/keepassxc
2 participants
@droidmonkey @shailen001