Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Words with spaces used for tags get split into multiple tags #7602

Closed
grivanov opened this issue Mar 23, 2022 · 0 comments · Fixed by #7708
Closed

Words with spaces used for tags get split into multiple tags #7602

grivanov opened this issue Mar 23, 2022 · 0 comments · Fixed by #7708
Assignees
@droidmonkey
Labels
bug feature: Tags
Milestone
v2.7.1

Comments

@grivanov
Copy link

Overview

I have a DB created with the original KeePass on Windows that have multiple words as tags but when I open that DB with KeePassXC, I get multiple tags, split by the spaces. Also, if I try to write a new tag in KeePassXC, the moment I hit the space button, it decides to start a new tag.

Steps to Reproduce

  1. Open a DB with tags with spaces or directly edit already existing entry in KeePassXC
  2. Start typing multiple-word tag, separated with spaces

Expected Behavior

Spaces should be allowed in tags. At least not break already existing tags with spaces, done with other KeePass programs

Actual Behavior

Tags get broken into multiple separate words, split by the spaces. For example a tag "this is tag" will be created as 3 separate tags: "this", "is", "tag", instead of just one.

Context

KeePassXC - Version 2.7.0
Revision: d7a9ef4
Distribution: AppImage

Qt 5.15.2
Debugging mode is disabled.

Operating system: Pop!_OS 21.10
CPU architecture: x86_64
Kernel: linux 5.16.11-76051611-generic

Enabled extensions:

  • Auto-Type
  • Browser Integration
  • SSH Agent
  • KeeShare
  • YubiKey
  • Secret Service Integration

Cryptographic libraries:

  • Botan 2.12.1

Operating System: Linux
Desktop Env: Gnome
Windowing System: Mutter
@grivanov grivanov added the bug label Mar 23, 2022
@droidmonkey droidmonkey added this to the v2.7.1 milestone Mar 23, 2022
@droidmonkey droidmonkey self-assigned this Mar 23, 2022
droidmonkey added a commit that referenced this issue Mar 29, 2022
@droidmonkey
Several improvements to tags editing
355cad4 
* Fix #7602 - Allow spaces in tag names
* Fix #7528 - Allow pasting text into the tags field. Text is split by comma creating tags for each section of text. If there are no commas then the pasted text becomes a tag.
* Fix tags editing not causing the entry to be marked as modified.
@droidmonkey droidmonkey mentioned this issue Mar 29, 2022
Merged
droidmonkey added a commit that referenced this issue Mar 29, 2022
@droidmonkey
Several improvements to tags editing
9af0ab3 
* Fix #7602 - Allow spaces in tag names
* Fix #7528 - Allow pasting text into the tags field. Text is split by comma creating tags for each section of text. If there are no commas then the pasted text becomes a tag.
* Fix tags editing not causing the entry to be marked as modified.
droidmonkey added a commit that referenced this issue Mar 29, 2022
@droidmonkey
Several improvements to tags editing
02602da 
* Fix #7602 - Allow spaces in tag names
* Fix #7528 - Allow pasting text into the tags field. Text is split by comma creating tags for each section of text. If there are no commas then the pasted text becomes a tag.
* Fix tags editing not causing the entry to be marked as modified.
pull bot pushed a commit to nonomal/keepassxc that referenced this issue Mar 30, 2022
@droidmonkey @pull
Several improvements to tags editing
50da766 
* Fix keepassxreboot#7602 - Allow spaces in tag names
* Fix keepassxreboot#7528 - Allow pasting text into the tags field. Text is split by comma creating tags for each section of text. If there are no commas then the pasted text becomes a tag.
* Fix tags editing not causing the entry to be marked as modified.
t-h-e pushed a commit to t-h-e/keepassxc that referenced this issue Sep 8, 2022
@droidmonkey @t-h-e
Several improvements to tags editing
ff5d319 
* Fix keepassxreboot#7602 - Allow spaces in tag names
* Fix keepassxreboot#7528 - Allow pasting text into the tags field. Text is split by comma creating tags for each section of text. If there are no commas then the pasted text becomes a tag.
* Fix tags editing not causing the entry to be marked as modified.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@droidmonkey droidmonkey

Labels
bug feature: Tags
Projects
None yet
Milestone
v2.7.1
Development

Successfully merging a pull request may close this issue.

Several improvements to tags editing keepassxreboot/keepassxc
2 participants
@droidmonkey @grivanov