Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show password strength indicator in EditForm and General Tab #7437

Closed
weilharter opened this issue Feb 20, 2022 · 8 comments · Fixed by #7885
Closed

Show password strength indicator in EditForm and General Tab #7437

weilharter opened this issue Feb 20, 2022 · 8 comments · Fixed by #7885
Assignees
Milestone

Comments

@weilharter
Copy link

weilharter commented Feb 20, 2022

Summary

A password strength indicator in EditEntryForm and below the Password (General tab) would be a cool feature

Examples

Example from Strongbox(MacOS Keepass Client)

Edit View:

editview

General Tab/Preview Pane:

generalinfo

@droidmonkey
Copy link
Member

You can show the password strength as a column in the entry view right now. It should be elsewhere, agree.

@schlimmchen
Copy link
Contributor

@droidmonkey Where exactly? Do you mean the database health check table?

@droidmonkey
Copy link
Member

No in the main entry table. Right click the header and you can add it as a column. You need version 2.6.6

@schlimmchen
Copy link
Contributor

It seems this was introduced after 2.6.6. I found that column immediately after firing up the current development snapshot AppImage.

@droidmonkey Any Feedback to the following mockups? @weilharter What did you have in mind (the context of your example screenshot of Strongbox is unclear)?

Copying the "entropy bar" from the password generator to the entry edit view:
entry_edit_view

Adding the password strength indicator to the edit preview pane (where it is always visible):
edit_preview_v1

Adding the password strength indicator with textual value in a new line of the preview pane (where it is always visible):
edit_preview_v2

@weilharter
Copy link
Author

weilharter commented Feb 21, 2022

What did you have in mind (the context of your example screenshot of Strongbox is unclear)?

Sorry for not checking the latest dev build. The entropy bar in Edit View looks perfect! That's exactly what I meant.

My Screenshot was showing the General Tab/Preview Pane-Equivalent of Strongbox Keepass Client. I just updated the issue with better Screenshots to show more context.

@michaelk83
Copy link

@schlimmchen I like the 1st version of the preview pane better. The color is enough to understand the strength without adding extra clutter. You can place the strength text in a tooltip of the strength indicator, along with the entropy. And same tooltip for the strength indicator in the table.

@schlimmchen
Copy link
Contributor

schlimmchen commented Feb 21, 2022

Sorry for not checking the latest dev build. The entropy bar in Edit View looks perfect! That's exactly what I meant.

Don't be sorry, what you see is just a mockup! The entropy bar is currently only used in the password generator widget, not in the entry edit view. What I found in the latest dev build is just the little colored square indicator in the list of entries for a group when enabling the respective column as droidmonkey suggested.

Thanks for updating the screenshots, those help.

@droidmonkey
Copy link
Member

Adding the strength indicator to the PasswordEditWidget would be a nice addition that could be toggled internally based on use (hidden by default). Adding the entropy is unnecessary, it really doesn't mean much, but placing the "Password quality: Excellent" text to the far right of the quality color bar would be nice.

@droidmonkey droidmonkey added this to the v2.7.1 milestone Mar 21, 2022
@droidmonkey droidmonkey self-assigned this Mar 21, 2022
@phoerious phoerious modified the milestones: v2.7.1, v2.7.2 Apr 12, 2022
jmdana added a commit to jmdana/keepassxc that referenced this issue Apr 13, 2022
jmdana added a commit to jmdana/keepassxc that referenced this issue Apr 13, 2022
jmdana added a commit to jmdana/keepassxc that referenced this issue Apr 14, 2022
jmdana added a commit to jmdana/keepassxc that referenced this issue Apr 14, 2022
droidmonkey pushed a commit to jmdana/keepassxc that referenced this issue May 28, 2022
droidmonkey pushed a commit to jmdana/keepassxc that referenced this issue May 28, 2022
droidmonkey pushed a commit that referenced this issue May 28, 2022
droidmonkey pushed a commit to jmdana/keepassxc that referenced this issue May 30, 2022
droidmonkey pushed a commit to jmdana/keepassxc that referenced this issue May 31, 2022
droidmonkey pushed a commit that referenced this issue May 31, 2022
droidmonkey pushed a commit that referenced this issue Jun 27, 2022
t-h-e pushed a commit to t-h-e/keepassxc that referenced this issue Sep 8, 2022
droidmonkey pushed a commit that referenced this issue Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants