Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download favicon for all entries without icon [$40 awarded] #735

Closed
janekbettinger opened this issue Jul 2, 2017 · 29 comments
Closed

Download favicon for all entries without icon [$40 awarded] #735

janekbettinger opened this issue Jul 2, 2017 · 29 comments
Assignees
Milestone

Comments

@janekbettinger
Copy link

janekbettinger commented Jul 2, 2017

Expected Behavior

  • Tools > Download and set missing icons
    It will download the favicon and set it as symbol for each entry (for which no icon was defined, yet)

Current Behavior

You have to download the favicon for every single entry.

Context

Having a huge database without any custom icons set, this new feature would dramatically reduce manual effort.

Update 2017/10/05: It might also be useful to add an option to force an update of existing favicons.

@xKeiro
Copy link

xKeiro commented Jul 22, 2017

Yeah this feature would be really awesome (after they get around fixing the favicon fetching)

@TheZ3ro
Copy link
Contributor

TheZ3ro commented Jul 22, 2017

@kusaha what is the problem with favicon fetching?

@xKeiro
Copy link

xKeiro commented Jul 22, 2017

@TheZ3ro
When you try to get favicon from "https://*" URLs keepassxc always fails to fetch them, showing this error:
2017-07-22_15-15-45_keepassxc
but there's already an open issue about this here: #678
(Note: I'm using windows 10, and the 64bit version of keepassxc)

@sergeevabc
Copy link

sergeevabc commented Jul 22, 2017

@kusaha, possible workaround is to use Favicon downloader plugin with original Keepass.

@droidmonkey droidmonkey changed the title [Feature Request] Download favicon for all entries without icon Download favicon for all entries without icon Sep 10, 2017
@droidmonkey droidmonkey added this to the v2.3.0 milestone Sep 10, 2017
@droidmonkey droidmonkey self-assigned this Dec 8, 2017
@phoerious phoerious modified the milestones: v2.3.0, v2.4.0 Jan 28, 2018
@tycho
Copy link
Contributor

tycho commented Feb 28, 2018

Just in case anyone else is having the same troubles I am...

For whatever reason I couldn't get the SourceForge mirrors to let me download the original Favicon downloader plugin for KeePass, so I'm using this plugin instead, which seems to work so far: https://github.com/navossoc/KeePass-Yet-Another-Favicon-Downloader

Looking forward to seeing this as a feature for KeePassXC so I can finally throw my old KeePass install away.

@JohnRobson
Copy link

I'm using KeePassXC 2.3.4 and I can't find this "favicon download" option. Where is this?

@droidmonkey
Copy link
Member

You need to define a url for the entry. Then go to the icon section on the left of the edit entry page. The button is at the bottom.

@sebast889
Copy link

An "Update all favicons" would also be useful. For first time downloading all favicons and for downloading and setting new favicons over old ones if there are any.

@varjolintu
Copy link
Member

I opened a work-in-progress PR that you can try: #3169.

@droidmonkey droidmonkey changed the title Download favicon for all entries without icon Download favicon for all entries without icon [$40 awarded] Dec 24, 2019
@zian92
Copy link

zian92 commented Apr 23, 2021

I did find a workaround:

  1. type * in the searchbar and it will list all the entries of your database.
  2. select all entries (e.g. ctrl + a)
  3. right klick, last entry ist: download Favicons
    This may take awhile to process all the entries but will soon start to download all icons

have fun! :)

@droidmonkey
Copy link
Member

Recommend turning off auto saving before doing the above

@JohnRobson
Copy link

Maybe increase the "Favicon download timeout" to 60 sec.

@droidmonkey
Copy link
Member

You can do that in the application settings

@machocam
Copy link

I did find a workaround:

1. type * in the searchbar and it will list all the entries of your database.

2. select all entries (e.g. ctrl + a)

3. right klick, last entry ist: download Favicons
   This may take awhile to process all the entries but will soon start to download all icons

have fun! :)

Not sure if there was an explicit feature built for this but this worked for me.

@Boldfor
Copy link

Boldfor commented Jan 29, 2023

Not sure if there was an explicit feature built for this but this worked for me.

Works great as a workaround!

@aetonsi
Copy link

aetonsi commented Jul 13, 2023

Where is the functionality located? Is it Entries>Download Favicons? Is it recursive?
Because, for me, it doesn't do anything. I have only Password Generator and Settings under Tools....

@varjolintu
Copy link
Member

@aetonsi Are you using "Use DuckDuckGo service to download website icons" from Application Settings -> Security?

@aetonsi
Copy link

aetonsi commented Jul 13, 2023

@varjolintu yes i am.
i also remember using this functionality to download all of the icons in my db, but i can't seem to find it anymore?

@droidmonkey
Copy link
Member

If there is already a custom icon on an entry, then the bulk download feature will NOT replace that icon. You need to do an individual download to replace a custom icon.

@aetonsi
Copy link

aetonsi commented Jul 16, 2023

If there is already a custom icon on an entry, then the bulk download feature will NOT replace that icon. You need to do an individual download to replace a custom icon.

i understand that, i am asking, where is this bulk download feature located? i thought it was under Tools, but maybe i don't remember correctly

@rugk
Copy link

rugk commented Jul 17, 2023

@aetonsi Just select all/the entries you want to download, right-click and choose “download favicon”.

@aetonsi
Copy link

aetonsi commented Jul 19, 2023

@aetonsi Just select all/the entries you want to download, right-click and choose “download favicon”.

.. and do that in every single folder? or just in the tree on the left? if i do it on the root, nothing happens. if i do it on individual folders it works

@droidmonkey
Copy link
Member

droidmonkey commented Jul 19, 2023

Do it in each folder (group).

@aetonsi
Copy link

aetonsi commented Jul 23, 2023

Just so i understand, the Download all favicons... on a Group/folder does not recurse through subfolders?
I have tens of folders and multiple levels of subfolders, it would be unfeasible manually doing that.. for now i solved by searching * and selecting all entries and doing download favicons on the entries themselves, but that's not very cool :\

@droidmonkey
Copy link
Member

Using the group option should recurse down the folder tree. Like I said, however, that will not replace already existing downloaded icons. To do that you need to do the entry selection option. Searching for * and doing the download is cool 😎

@aetonsi
Copy link

aetonsi commented Jul 23, 2023

Ok so it should recurse.. unluckily it doesn't, when i do it on the root group (the database). Nothing at all happens. No popup, no nothing.
It works, instead, on subfolders.
Is there a log or something i can check to look for errors?

@droidmonkey
Copy link
Member

It does not recurse, although I can't decide if this is desired behavior or not. Recursing could be seen as a negative behavior.

https://github.com/keepassxreboot/keepassxc/blob/develop/src/gui/DatabaseWidget.cpp#L852

@aetonsi
Copy link

aetonsi commented Jul 23, 2023

Oh ok. So the * search trick is the only way to do it on the whole database, correct?

@droidmonkey
Copy link
Member

Correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests