In-browser password generator does not respect "Also include" saved settings from KeepassXC window

[xenithorb]

Expected Behavior

The in-browser password generator does not incude chars from the "Also include from" list that are saved sttings in the main keepassxc window. This results in potentially creating passwords with unexpected properties.

Current Behavior

Currently, if you set a list of chars that you wish to be added to meet password requirements like say $%^&* - the in-browser password generator function does not include these characters into the in-browser generated password. I have observed that all other settings are carried over from KeepassXC such as length, etc, but not the explicit list of chars.

Possible Solution

Steps to Reproduce (for bugs)

1. Go to KeepassXC password generator, add a list to the "also include" input box like @#$%&!
2. Make sure no other special char buttons are enabled, so you should only have alphanumeric chars enbaled by default. Be sure to close the password generator window to save settings
3. Go to a password entry field with keepassxc-browser
4. Allow keepassxc-browser to generate a new password on the spot... Click generate a few times.
5. Notice that none of the special chars you explicitly added are present in the generated material

Debug info

KeePassXC - 2.6.4
KeePassXC-Browser - 1.7.7
Operating system: Linux, Fedora 33
Browser: Chromium, Brave

[droidmonkey]

We need to either:

1. Use the pop-up password generator directly from keepassxc (similar to entry edit version)
2. Incorporate the password tuning controls into the browser view

I vote for # 1

[varjolintu]

This probably needs a fix to KeePassXC side. The password is retrieved directly from BrowserSettings::generatePassword(). We must make sure all options are included in that function.

[varjolintu]

Passphrase option seems to be broken too.