Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a password quality check for the database password #5220

Closed
Noir- opened this issue Aug 3, 2020 · 3 comments · Fixed by #7885
Closed

Add a password quality check for the database password #5220

Noir- opened this issue Aug 3, 2020 · 3 comments · Fixed by #7885
Milestone

Comments

@Noir-
Copy link

Noir- commented Aug 3, 2020

Summary

When creating a new database, there're the plain password input fields without any quality checks. But the choice of this password is very essential since the secrecy of all the credentials depends on this password. Therefore there should be a quality check in place to guide the user with creating the password. The user could already do that in the password generator but the chances are good that we have a first-time user who doesn't even know how to handle that. It's also pretty counter-intuitive because auto-generating a password is not what a user wants in most cases.

Examples

I think having this bar under the first input field would help in the first place.
image

Bonus: But there could be some very simple hints for making the password better as well. It could be very generic like "add more length" or "avoid common patterns". This addition could be helpful in the other places where password strength is measured as well but might be subject for a separate request tho.

Context

I'm dealing with a lot of users who are not tech-savvy in non-profit organizations and in private life. I tell them a lot about (password) security and most of them are trying their best in doing things better. But it would help everyone having a tool at hand which makes it easier to follow these best practices.

@droidmonkey
Copy link
Member

Good ideas, this is technically a duplicate request but I love your writeup.

@droidmonkey droidmonkey added this to the v2.7.0 milestone Aug 5, 2020
@Noir-
Copy link
Author

Noir- commented Aug 24, 2020

Thank you! :)
I'm planning to get involved into this and this looks like a low-hanging fruit.

@tunbridgep
Copy link

The master password should also show in the health report if it's weak or used within the database itself

@droidmonkey droidmonkey modified the milestones: v2.7.0, v2.7.1 Mar 21, 2022
@phoerious phoerious modified the milestones: v2.7.1, v2.7.2 Apr 12, 2022
jmdana added a commit to jmdana/keepassxc that referenced this issue Apr 13, 2022
jmdana added a commit to jmdana/keepassxc that referenced this issue Apr 13, 2022
jmdana added a commit to jmdana/keepassxc that referenced this issue Apr 14, 2022
jmdana added a commit to jmdana/keepassxc that referenced this issue Apr 14, 2022
droidmonkey pushed a commit to jmdana/keepassxc that referenced this issue May 28, 2022
droidmonkey pushed a commit to jmdana/keepassxc that referenced this issue May 28, 2022
droidmonkey pushed a commit that referenced this issue May 28, 2022
droidmonkey pushed a commit to jmdana/keepassxc that referenced this issue May 30, 2022
droidmonkey pushed a commit to jmdana/keepassxc that referenced this issue May 31, 2022
droidmonkey pushed a commit that referenced this issue May 31, 2022
droidmonkey pushed a commit that referenced this issue Jun 27, 2022
t-h-e pushed a commit to t-h-e/keepassxc that referenced this issue Sep 8, 2022
droidmonkey pushed a commit that referenced this issue Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants