Change meaning of F1-F2-F3 shortcuts

[fpohtmeh-github]

Overview

App has 3 undocumented shortcuts for changing of focus: F1, F2, F3. In other software they are reserved for another functionality, so current behavior is confusing.

Steps to Reproduce

Press F1, F2, F3 in main window.

Expected Behavior

F1 - show help
F2 - edit value in table or list
F3 - find next. Shift+F3 - find previous. Or disable F3 at all.

Actual Behavior

App changes focus

[droidmonkey]

So you would prefer they did absolutely nothing like before? I detest F1 opening help, there are no fields in keepassxc where F2 type "edit in place" action can happen, and F3 focuses search.

[fpohtmeh-github]

• Ok, probably F1 is the history, no need to open help.

• F2 is my main misunderstanding here. It's default Qt shortcut for editing of value in place. There are at least 3 places where it looks natural:

1. Edit entry / Edit name of attribute in list
2. Edit entry / Edit attachment name (it's upcoming feature Rename attachments #5034)
3. Edit group (name) in tree

Basically it should work for any Q*****View if it's not read-only.
Optionally, we can edit entry on F2. It's not "edit in place", but it's another kind of association of F2 and editing.

• F3 looks better for search than F1. In my opinion

[droidmonkey]

F1 groups (if already on groups edit the current group), F2 entries (if already on entries then edit the current selected entry), F3 focus search. I can disable taking over F2 if the entry view is not visible, then it defaults to normal behavior.

[fpohtmeh-github]

I like that we move in F2 default functionality direction.
How about idea to use F3-F4-F5 instead of F1-F2-F3? We will leave F2 for a single action, it will not work differently depending on the context.
Moreover F1-F2-F3 triple isn't documented and probably is not widely used.

[droidmonkey]

I considered shifting to the higher keys but that's even more obtuse. The non documentation was a mistake and not intentional.

[fpohtmeh-github]

F1 groups (if already on groups edit the current group), F2 entries (if already on entries then edit the current selected entry), F3 focus search. I can disable taking over F2 if the entry view is not visible, then it defaults to normal behavior.

Ok, let's stop on this