Add setting for not displaying KeePassHTTP migration popup #3349

varjolintu · 2019-07-02T08:57:46Z

Type of change

✅ New feature (non-breaking change which adds functionality)

Description and Context

Add an extra option for not displaying legacy KeePassHTTP setting popup. This is an add to the previous PR #3327.

Also extends the MessageBox class to include an optional checkbox.

Screenshots

Testing strategy

Manually.

Checklist:

✅ I have read the CONTRIBUTING document. [REQUIRED]
✅ My code follows the code style of this project. [REQUIRED]
✅ All new and existing tests passed. [REQUIRED]
✅ I have compiled and verified my code with -DWITH_ASAN=ON. [REQUIRED]

droidmonkey · 2019-07-02T19:40:14Z

src/browser/BrowserService.cpp

+                    "Would you like to migrate your existing settings now?");
+    auto noButton = warning.addButton(QMessageBox::No);
+    auto yesButton = warning.addButton(QMessageBox::Yes);
+    auto rememberButton = warning.addButton(tr("No. Don't ask again."), QMessageBox::ButtonRole::RejectRole);


Couple things here. This should be using the custom MessageBox class. Also, instead of adding a dedicated button, use the MessageBox::setCheckBox(...) function to add a checkbox with the following text: tr("Don't show this warning again") which is already translated.

The only reason I used this implementation is that MessageBox class' constuctor executes the popup right away and returns the the button pressed. There's no default constructor available. So maybe this class needs to be extended to hold a checkbox inside if configured so.

Necessary changes has been made.

Hmmm that is a good point

I was mistaken when I looked at the code yesterday, the other example for a checkbox used the QMessageBox directly. However, I do like what you did so we can now convert the other example to using MessageBox. The benefit of MessageBox is you can set a "next answer" during GUI testing to dismiss the box correctly.

Added - Add 'Paper Backup' aka 'Export to HTML file' to the 'Database' menu [[#3277](#3277)] - Add statistics panel with information about the database (number of entries, number of unique passwords, etc.) to the Database Settings dialog [[#2034](#2034)] - Add offline user manual accessible via the 'Help' menu [[#3274](#3274)] - Add support for importing 1Password OpVault files [[#2292](#2292)] - Implement Freedesktop.org secret storage DBus protocol so that KeePassXC can be used as a vault service by libsecret [[#2726](#2726)] - Add support for OnlyKey as an alternative to YubiKeys (requires yubikey-personalization >= 1.20.0) [[#3352](#3352)] - Add group sorting feature [[#3282](#3282)] - Add feature to download favicons for all entries at once [[#3169](#3169)] - Add word case option to passphrase generator [[#3172](#3172)] - Add support for RFC6238-compliant TOTP hashes [[#2972](#2972)] - Add UNIX man page for main program [[#3665](#3665)] - Add 'Monospaced font' option to the notes field [[#3321](#3321)] - Add support for key files in auto open [[#3504](#3504)] - Add search field for filtering entries in Auto-Type dialog [[#2955](#2955)] - Complete usernames based on known usernames from other entries [[#3300](#3300)] - Parse hyperlinks in the notes field of the entry preview pane [[#3596](#3596)] - Allow abbreviation of field names in entry search [[#3440](#3440)] - Allow setting group icons recursively [[#3273](#3273)] - Add copy context menu for username and password in Auto-Type dialog [[#3038](#3038)] - Drop to background after copying a password to the clipboard [[#3253](#3253)] - Add 'Lock databases' entry to tray icon menu [[#2896](#2896)] - Add option to minimize window after unlocking [[#3439](#3439)] - Add option to minimize window after opening a URL [[#3302](#3302)] - Request accessibility permissions for Auto-Type on macOS [[#3624](#3624)] - Browser: Add initial support for multiple URLs [[#3558](#3558)] - Browser: Add entry-specific browser integration settings [[#3444](#3444)] - CLI: Add offline HIBP checker (requires a downloaded HIBP dump) [[#2707](#2707)] - CLI: Add 'flatten' option to the 'ls' command [[#3276](#3276)] - CLI: Add password generation options to `Add` and `Edit` commands [[#3275](#3275)] - CLI: Add XML import [[#3572](#3572)] - CLI: Add CSV export to the 'export' command [[#3278](#3278)] - CLI: Add `-y --yubikey` option for YubiKey [[#3416](#3416)] - CLI: Add `--dry-run` option for merging databases [[#3254](#3254)] - CLI: Add group commands (mv, mkdir and rmdir) [[#3313](#3313)]. - CLI: Add interactive shell mode command `open` [[#3224](#3224)] Changed - Redesign database unlock dialog [ [#3287](#3287)] - Rework the entry preview panel [ [#3306](#3306)] - Move notes to General tab on Group Preview Panel [[#3336](#3336)] - Enable entry actions when editing an entry and cleanup entry context menu [[#3641](#3641)] - Improve detection of external database changes [[#2389](#2389)] - Warn if user is trying to use a KDBX file as a key file [[#3625](#3625)] - Add option to disable KeePassHTTP settings migrations prompt [[#3349](#3349), [#3344](#3344)] - Re-enabled Wayland support (no Auto-Type yet) [[#3520](#3520), [#3341](#3341)] - Add icon to 'Toggle Window' action in tray icon menu [[3244](#3244)] - Merge custom data between databases only when necessary [[#3475](#3475)] - Improve various file-handling related issues when picking files using the system's file dialog [[#3473](#3473)] - Add 'New Entry' context menu when no entries are selected [[#3671](#3671)] - Reduce default Argon2 settings from 128 MiB and one thread per CPU core to 64 MiB and two threads to account for lower-spec mobile hardware [ [#3672](#3672)] - Browser: Remove unused 'Remember' checkbox for HTTP Basic Auth [[#3371](#3371)] - Browser: Show database name when pairing with a new browser [[#3638](#3638)] - Browser: Show URL in allow access dialog [[#3639](#3639)] - CLI: The password length option `-l` for the CLI commands `Add` and `Edit` is now `-L` [[#3275](#3275)] - CLI: The `-u` shorthand for the `--upper` password generation option has been renamed to `-U` [[#3275](#3275)] - CLI: Rename command `extract` to `export`. [[#3277](#3277)] Fixed - Improve accessibility for assistive technologies [[#3409](#3409)] - Correctly unlock all databases if `--pw-stdin` is provided [[#2916](#2916)] - Fix password generator issues with special characters [[#3303](#3303)] - Fix KeePassXC interrupting shutdown procedure [[#3666](#3666)] - Fix password visibility toggle button state on unlock dialog [[#3312](#3312)] - Fix potential data loss if database is reloaded while user is editing an entry [[#3656](#3656)] - Fix hard-coded background color in search help popup [[#3001](#3001)] - Fix font choice for password preview [[#3425](#3425)] - Fix handling of read-only files when autosave is enabled [[#3408](#3408)] - Handle symlinks correctly when atomic saves are disabled [[#3463](#3463)] - Enable HighDPI icon scaling on Linux [[#3332](#3332)] - Make Auto-Type on macOS more robust and remove old Carbon API calls [[#3634](#3634), [[#3347](#3347))] - Hide Share tab if KeePassXC is compiled without KeeShare support and other minor KeeShare improvements [[#3654](#3654), [[#3291](#3291), [#3029](#3029), [#3031](#3031), [#3236](#3236)] - Correctly bring window to the front when clicking tray icon on macOS [[#3576](#3576)] - Correct application shortcut created by MSI Installer on Windows [[#3296](#3296)] - Fix crash when removing custom data [[#3508](#3508)] - Fix placeholder resolution in URLs [[#3281](#3281)] - Fix various inconsistencies and platform-dependent compilation bugs [[#3664](#3664), [#3662](#3662), [#3660](#3660), [#3655](#3655), [#3649](#3649), [#3417](#3417), [#3357](#3357), [#3319](#3319), [#3318](#3318), [#3304](#3304)] - Browser: Fix potential leaking of entries through the browser integration API if multiple databases are opened [[#3480](#3480)] - Browser: Fix password entropy calculation [[#3107](#3107)] - Browser: Fix Windows registry settings for portable installation [[#3603](#3603)]

varjolintu added the feature: Browser label Jul 2, 2019

varjolintu added this to the v2.5.0 milestone Jul 2, 2019

varjolintu requested a review from droidmonkey July 2, 2019 08:57

varjolintu force-pushed the feature/no_http_migration_prompt branch from 82545f2 to 20afeea Compare July 2, 2019 08:58

droidmonkey requested changes Jul 2, 2019

View reviewed changes

varjolintu force-pushed the feature/no_http_migration_prompt branch from 20afeea to 2e59351 Compare July 3, 2019 08:34

Add setting for not displaying KeePassHTTP migration popup

dadd272

varjolintu force-pushed the feature/no_http_migration_prompt branch from 2e59351 to dadd272 Compare July 3, 2019 08:35

droidmonkey approved these changes Jul 3, 2019

View reviewed changes

droidmonkey merged commit c27ee6a into keepassxreboot:develop Jul 3, 2019

varjolintu deleted the feature/no_http_migration_prompt branch July 3, 2019 15:07

mendhak mentioned this pull request Sep 3, 2019

Incessant nagging to destroy KeePassHttp rules #3346

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add setting for not displaying KeePassHTTP migration popup #3349

Add setting for not displaying KeePassHTTP migration popup #3349

varjolintu commented Jul 2, 2019 •

edited

Loading

droidmonkey Jul 2, 2019

varjolintu Jul 3, 2019

varjolintu Jul 3, 2019

droidmonkey Jul 3, 2019

droidmonkey Jul 3, 2019

Add setting for not displaying KeePassHTTP migration popup #3349

Add setting for not displaying KeePassHTTP migration popup #3349

Conversation

varjolintu commented Jul 2, 2019 • edited Loading

Type of change

Description and Context

Screenshots

Testing strategy

Checklist:

droidmonkey Jul 2, 2019

Choose a reason for hiding this comment

varjolintu Jul 3, 2019

Choose a reason for hiding this comment

varjolintu Jul 3, 2019

Choose a reason for hiding this comment

droidmonkey Jul 3, 2019

Choose a reason for hiding this comment

droidmonkey Jul 3, 2019

Choose a reason for hiding this comment

varjolintu commented Jul 2, 2019 •

edited

Loading