💻💻 CLI password generation options cleanup

[louib]

Summary of changes:

• extract function for creating password generator from options into
  Generate command. This function is now reused in Add and Edit
  commands.
• Updated manpage with missing password generation options.
• Updated manpage with missing longer forms of password generation options.
• Added unit tests for new password generation options in Add and
  Edit.
• Handle case when -g and -p options are used at the same time.

This PR adds password generation functionalities while reducing
code duplication, but at the cost of 2 small breaking changes:

• the password generation option for Add and Edit for specifying
  password length is now -L instead of -l, to not clash with the
  -l --lower option.
• the -u shorthand for the --upper option had to be renamed to -U, to not
  clash with the -u --username option.

@droidmonkey what about the CHANGELOG file, should I update it with the breaking changes now, or do you wait before the releases to do that?

Type of change

• ✅ Bug fix
• ✅ Refactor
• ✅ New feature
• ✅ Breaking change
• ✅ Documentation

Testing strategy

existing + new unit tests.

Checklist:

• ✅ I have read the CONTRIBUTING document. [REQUIRED]
• ✅ My code follows the code style of this project. [REQUIRED]
• ✅ All new and existing tests passed. [REQUIRED]
• ✅ I have compiled and verified my code with -DWITH_ASAN=ON. [REQUIRED]
• ✅ My change requires a change to the documentation, and I have updated it accordingly.
• ✅ I have added tests to cover my changes.

[droidmonkey]

Please do update the CHANGELOG. You can use a "2.5.0-Beta1" title. I actually like the idea of gradually growing the log with major PR's so I don't miss any important bits later on.

[louib]

@droidmonkey I added the 2 breaking changes to the CHANGELOG as well as a line about the new options. Is it clear that 💥 means a breaking change? 😆

[drone540]

Why not keep the -u option for the --upper password generation, and make the --username option use -U, or vice versa (-U = upper, -u = username). As it stands right now, it's missing a shorthand option if you wanted to do something like -ulnse to use all the groups.

Edit: looks like -u was for username first. so maybe just use -U for --upper

[droidmonkey]

-U for upper makes a lot of sense

[louib]

@drone540 @droidmonkey good call, renamed to -U instead of removing the shorthand altogether.

[louib]

@phoerious @droidmonkey looks like the MacOS tests are hanging now 😬 😬

[droidmonkey]

Please ignore, the macOS server is currently down