Add [optional?] confirmation before "destructive" things like group deletion #2125
Labels
Comments
|
Good idea |
kneitinger
added a commit
to kneitinger/keepassxc
that referenced
this issue
Oct 9, 2018
Spawn a yes/no QMessage box when "Delete Group" is selected on a group that is not already in the recycle bin (note: the prompt for deletion from the recycle bin was already implemented). This follows the same pattern and language as entry deletion. Fixes keepassxreboot#2125
droidmonkey
pushed a commit
that referenced
this issue
Dec 20, 2018
* Add confirmation prompt before moving groups to the recycling bin Spawn a yes/no QMessage box when "Delete Group" is selected on a group that is not already in the recycle bin (note: the prompt for deletion from the recycle bin was already implemented). This follows the same pattern and language as entry deletion. Fixes #2125 * Make prompts for destructive operations use action words on buttons Replace yes/no, yes/cancel (and other such buttons on prompts that cause data to be destroyed) use language that indicates the action that it is going to take. This makes destructive/unsafe and/or irreversible operations more clear to the user. Address feedback on PR #2376 * Refactor MessageBox class to allow for custom buttons Replaces arguments and return values of type QMessageBox::StandardButton(s) with MessageBox::Button(s), which reimplements the entire set of QMessageBox::StandardButton and allows for custom KeePassXC buttons, such as "Skip". Modifies all calls to MessageBox functions to use MessageBox::Button(s). Addresses feedback on #2376 * Remove MessageBox::addButton in favor of map lookup Replaced the switch statement mechanism in MessageBox::addButton with a map lookup to address CodeFactor Complex Method issue. This has a side-effect of a small performance/cleanliness increase, as an extra QPushButton is no longer created/destroyed (to obtain it's label text) everytime a MessageBox button based on QMessageBox::StandardButton is created; now the text is obtained once, at application start up.
|
Would be a good idea. At the moment, all you have to do is press delete button on your keyboard and your key/entry is gone. This is not good. At least make such a feature optional. My current workaround is not to automatically save the DB after changes. |
|
It goes to your recycle bin in the database by default.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I just deleted a whole group be accident because I "misclicked" somehow, wasn't even sure and just found out by looking into the Recycle bin.
It would be nice to have at least an optional confirmation dialogue to prevent those cases. There is a confirmation dialogue before the final deletion in the Recycle bin so maybe it would be possible to activate it for regular entries as well.
Expected Behavior
Before clicking a confirmation dialogue should appear.
Current Behavior
A deleted group just disappears. No other verbose information about this.
Steps to Reproduce (for bugs)
Context
I described it already.
Debug Info
KeePassXC - Version 2.3.3
Revision: 0a155d8
Libraries:
Operating system: Ubuntu 17.10
CPU architecture: x86_64
Kernel: linux 4.13.0-46-generic
Enabled extensions:
The text was updated successfully, but these errors were encountered: