Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL not shown in entry table if scheme is not http/https #1424

Closed
apiraino opened this issue Jan 25, 2018 · 8 comments
Closed

URL not shown in entry table if scheme is not http/https #1424

apiraino opened this issue Jan 25, 2018 · 8 comments

Comments

@apiraino
Copy link

apiraino commented Jan 25, 2018

A minor glitch. Created an entry in keepassxc for an ftp site:

Title: FreeBSD ftp
Username: ftpuser
Password: ******
URL: ftp://ftp.freebsd.org/

This item appears with an empty URL on the password listing. Anything but http/https shows a blank URL on the password listing.

Expected Behavior

Strip spaces from urls when saved, support any protocol scheme

Current Behavior

Only http/https URLs are shown, url is not stripped

Steps to Reproduce (for bugs)

  1. Start keepassxc, open password database
  2. CTRL+N
  3. Insert sample data above and save
  4. Password listing shows the new item but url field is empty

Operating system: Ubuntu 17.10
Browser: Firefox 59.0b3
Proxy used: YES

Debug Info

KeePassXC - Version 2.2.4
Revision: 83f1a53

Libraries:

  • Qt 5.9.1
  • libgcrypt 1.7.8

Operating system: Ubuntu 17.10
CPU architecture: x86_64
Kernel: linux 4.13.0-31-generic

Enabled extensions:

  • Auto-Type
  • Browser Integration
@apiraino apiraino changed the title Password entry URL not shown if scheme different is not http/https Password entry URL not shown if scheme is not http/https Jan 25, 2018
@varjolintu
Copy link
Member

Could you provide some more details about this or exact steps to reproduce it? Did you create the entry from the browser extension or it's already created in KeePassXC but not accessed properbly in the extension?

@varjolintu varjolintu self-assigned this Jan 25, 2018
@apiraino
Copy link
Author

Hi, I've updated my bug report with the steps to reproduce. Please note that the browser extension is not involved (sorry for not being clearer)

@eNTi
Copy link

eNTi commented Mar 1, 2018

When is this fix going to hit stable?

@TheZ3ro
Copy link
Contributor

TheZ3ro commented Mar 1, 2018

I think 2.3.1

@droidmonkey droidmonkey changed the title Password entry URL not shown if scheme is not http/https URL not shown in entry table if scheme is not http/https Mar 11, 2018
@droidmonkey droidmonkey added this to the v2.4.0 milestone Mar 17, 2018
@tylert
Copy link

tylert commented Mar 21, 2018

This issue is still a problem in 2.3.1. If the scheme is http:// or https://, the URL displays correctly. If you omit the scheme, it automatically assumes http://.

I have been adding other schemes such as smtp://, smtps://, ssh://, hostname://, ssid:// and so on for other types I use to prevent them from being automatically assumed to be http://.

@Trikas77
Copy link

Trikas77 commented Jun 28, 2018

Additionally:
I used for a long time the scheme 'android-package://' for an Android App which provided auto-fill functionality.
I now changed the App and it doesn't find 'android-package://' anymore so I'm removing it and end up with the without any scheme.

Those entries are almost all references.

What happens to me now due to this bug is (in the overview view), when I keep the Scheme 'android-package://' the URL field is empty.

When I remove the Scheme and just keep I get to see the URL of the reference Item.

@apiraino
Copy link
Author

I'm following this PR #1768

@droidmonkey
Copy link
Member

This was fixed in 2.3.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants