Suggestion: Improve UI on generating new passwords

[TeemuKoivisto]

Problem

Often times it has happened to me when I have generated a new password I have absent-mindedly clicked 'Ok' without first clicking 'Accept' for the new password. (Granted I have been using KeePassX but it seems that the functionality is the same in KeePassXC)

This has caused me to require password resets for accounts to which I have changed passwords but forgot to click accept. Most annoyingly for some accounts I have had ask my superior to reset it for me.

Solution

Turn password generation into its own modal. This way user has to either accept the generated password or dismiss the modal without accepting. Either way they can't just click 'Ok' and lose their generated password.

Or maybe disable 'Ok' button when the password generation is open. That would then also require a cancel/reject button for the password generation. So maybe it would better to replace the 'Cancel' and 'Ok' buttons with the password generation buttons so it's obvious that the newly generated password has to be either accepted or rejected.

But these are just my suggestions and anything that would fix the issue of being able to click 'Ok' without actually saving the password changes would be much appreciated. Before somebody tells me that this is not an issue and that I should just 'learn how to use it' well I had this problem when I first started using it and still, after 6 months, I do the same mistake again so I think it's an issue and not just my own stupidity.

[sts10]

As an alternate and lighter-weight solution, what if there was a warning dialog when users hit "OK" while the password generator is open that says something like "Are you sure you want to leave this entry before applying your generated password?"

[hifi]

I've also noticed that I have done this more than once. Preventing the user from accidentally discarding a generated password would be nice.

[TheZ3ro]

I will try to make a patch for this in the upcoming 2.3.0 version

[droidmonkey]

Merged in 2.3.0