Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sortable last-modified column to entry list view #129

Closed
TheZ3ro opened this issue Dec 19, 2016 · 9 comments
Closed

Add sortable last-modified column to entry list view #129

TheZ3ro opened this issue Dec 19, 2016 · 9 comments
Milestone

Comments

@TheZ3ro
Copy link
Contributor

TheZ3ro commented Dec 19, 2016

Add sortable last-modified column to entry list view
keepassx/keepassx#192

From KeePassX Pull Request

@droidmonkey
Copy link
Member

This is a nice solution but it doesn't solve the root problem which is not being able to customize the view in any way. This would be a great feature to bring to the app in the future.

@Thynix
Copy link

Thynix commented Jan 1, 2017

Aside from the test failure and a few minor comments that PR looks good to me.

@TheZ3ro
Copy link
Contributor Author

TheZ3ro commented Apr 1, 2017

Sub-issue of #17

@droidmonkey droidmonkey modified the milestones: v2.2.0, v2.2.1 May 30, 2017
@jab416171
Copy link

@Thynix it looks like it's just a matter of updating that one line of that one test. I can take care of that and submit a pull request against this repository with the same diff as keepassx/keepassx#192 if that's all it takes?

@Thynix
Copy link

Thynix commented Jun 19, 2017

@jab416171 I'm hardly in a position of authority here but that sounds good to me.

@jab416171
Copy link

Oh right, maybe I should be asking @TheZ3ro and @droidmonkey.

@droidmonkey
Copy link
Member

My thoughts on this were to wait until we redo the whole display of entries. I want it to be more extensible and less hard coded then it currently​ is.

@fonic
Copy link
Contributor

fonic commented Aug 7, 2017

Covered by #849

@droidmonkey
Copy link
Member

droidmonkey commented Oct 11, 2017

My mistake...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants