Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Placeholder not resolved in preview panel #10961

Closed
agowa opened this issue Jun 23, 2024 · 4 comments · Fixed by #11291
Closed

Placeholder not resolved in preview panel #10961

agowa opened this issue Jun 23, 2024 · 4 comments · Fixed by #11291

Comments

@agowa
Copy link

agowa commented Jun 23, 2024

Overview

Currently (2.7.9) KeepassXC doesn't resolve placeholders like {USERNAME} in the Preview panel. However it resolves them correctly when copying them.

Steps to Reproduce

  1. Create an entry with username "foo" and password "bar"
  2. Create a custom attribute named "foobar" and enter the value {USERNAME}
  3. Click on "View" and enable "Show Preview Panel"
  4. Switch to the "Advanced" tab in the preview panel and look at the "foobar" entry.

Expected Behavior

Either
a) show the resolved value as the value of the entry in the preview panel
b) Show both the placeholder and resolved value as the value in the preview panel like in the q'n'd mock-up below.

Actual Behavior

Shows the placeholder as if it was the value of the custom attribute.

Context

Q'n'D mockup of possible GUI for showing both the placeholder and it's resolved value (alternatively add the typical link symbol almost every OS has and show the placeholder itself on mouse over and the resolved value like a normal value).
image

KeePassXC - Version 2.7.9
Revision: 8f6dd13

Qt 5.15.14
Debugging mode is disabled.

Operating system: Arch Linux
CPU architecture: x86_64
Kernel: linux 6.9.5-arch1-1

Enabled extensions:

  • Auto-Type
  • Browser Integration
  • Passkeys
  • SSH Agent
  • KeeShare
  • YubiKey
  • Secret Service Integration

Cryptographic libraries:

  • Botan 3.4.0

Operating System: Linux
Desktop Env: KDE
Windowing System: Wayland

@agowa agowa added the bug label Jun 23, 2024
@droidmonkey
Copy link
Member

The placeholder is actually {Username}

@agowa
Copy link
Author

agowa commented Jun 23, 2024

The original keepass documentation says {USERNAME} and it works for copying the value ;-)

Am I really hitting all of the edge cases today? :D

Edit: Also doesn't work in the preview pannel
image

@droidmonkey
Copy link
Member

droidmonkey commented Jun 23, 2024

Ah both {USERNAME} and {Username} work because they are special cases. Custom attributes referenced using the {S: prefix are case sensitive. Typically attribute placeholders are case sensitive.

There are two bugs here:

  1. Preview panel, advanced tab, doesn't show filled placeholders
  2. When double clicking and advanced attribute value in the preview panel, the copied value is also not filled in

@www-wagner
Copy link

Other types of placeholders has issues since 2.7.9 (Flatpak version) as well. I have some entries with the reference {REF:U@T:title}. Besides it isn't showing the resolved value in list and preview, not even copying and pasting is working as expected, where the placeholder itself is being copied.

droidmonkey added a commit that referenced this issue Sep 23, 2024
@github-project-automation github-project-automation bot moved this to To triage in WIP Tracker Sep 23, 2024
@droidmonkey droidmonkey moved this from To triage to In review in WIP Tracker Sep 23, 2024
droidmonkey added a commit that referenced this issue Oct 8, 2024
* Fixes #10961
* Fixes #7410 - show content of references when previewing notes
droidmonkey added a commit that referenced this issue Oct 14, 2024
* Fixes #10961
* Fixes #7410 - show content of references when previewing notes
@github-project-automation github-project-automation bot moved this from In review to Done in WIP Tracker Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants