-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minimum Qt version? #10859
Comments
We are bumping it to 5.12 then 6.6 (I think that's the current lts) |
c4rlo
added a commit
to c4rlo/keepassxc
that referenced
this issue
Jun 14, 2024
Bump the minimum required Qt version up to 5.12, as per keepassxreboot#10859 (comment). Previously, the minimum version was 5.2.0 based on the CMakeLists.txt check, though it's unclear if such old versions would actually work. With this, we are able to remove a whole bunch of #ifdef'd code.
Merged
c4rlo
added a commit
to c4rlo/keepassxc
that referenced
this issue
Jun 14, 2024
Bump the minimum required Qt version up to 5.12, as per keepassxreboot#10859 (comment). Previously, the minimum version was 5.2.0 based on the CMakeLists.txt check, though it's unclear if such old versions would actually work. With this, we are able to remove a whole bunch of #ifdef'd code.
c4rlo
added a commit
to c4rlo/keepassxc
that referenced
this issue
Jun 14, 2024
Bump the minimum required Qt version up to 5.12, as per keepassxreboot#10859 (comment). Previously, the minimum version was 5.2.0 based on the CMakeLists.txt check, though it's unclear if such old versions would actually work. With this, we are able to remove a whole bunch of #ifdef'd code.
droidmonkey
pushed a commit
to c4rlo/keepassxc
that referenced
this issue
Jun 22, 2024
Bump the minimum required Qt version up to 5.12, as per keepassxreboot#10859 (comment). Previously, the minimum version was 5.2.0 based on the CMakeLists.txt check, though it's unclear if such old versions would actually work. With this, we are able to remove a whole bunch of #ifdef'd code.
droidmonkey
pushed a commit
that referenced
this issue
Jun 22, 2024
Bump the minimum required Qt version up to 5.12, as per #10859 (comment). Previously, the minimum version was 5.2.0 based on the CMakeLists.txt check, though it's unclear if such old versions would actually work. With this, we are able to remove a whole bunch of #ifdef'd code.
pull bot
pushed a commit
to tigerwill90/keepassxc
that referenced
this issue
Jun 23, 2024
Bump the minimum required Qt version up to 5.12, as per keepassxreboot#10859 (comment). Previously, the minimum version was 5.2.0 based on the CMakeLists.txt check, though it's unclear if such old versions would actually work. With this, we are able to remove a whole bunch of #ifdef'd code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What is the project's minimum required Qt version at this point? It would be nice to state this somewhere for reference.
As I said in my original PR description for #7783, I've been assuming 5.9.5 as the minimum version, as that was stated in INSTALL.md at the time; but as of #10088, it no longer mentions a minimum version requirement. Instead, we now have:
keepassxc/vcpkg.json
Lines 37 to 40 in c81e4e1
But also:
keepassxc/CMakeLists.txt
Lines 515 to 517 in c81e4e1
(Currently, my #7783 includes a commit to change the above to require 5.9.5.)
I ask because there are a bunch of
QT_VERSION_CHECK
s in the code (including some new ones in #7783), some of which could potentially be deleted now, depending on the minimum Qt version we want to impose. I'd be happy to submit a PR for that cleanup, if I knew which Qt version to target. (Of course, we eventually want to migrate to Qt 6, in #10267, but that might be a while yet I imagine.)The text was updated successfully, but these errors were encountered: