Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging always marks the database as dirty #1010

Closed
louib opened this issue Sep 29, 2017 · 2 comments
Closed

Merging always marks the database as dirty #1010

louib opened this issue Sep 29, 2017 · 2 comments

Comments

@louib
Copy link
Member

louib commented Sep 29, 2017

No matter if changes were made to the destination database, merging always marks it as dirty (modified).

Expected Behavior

The database is marked as changed only if the merge operation resulted in a change.

Current Behavior

The database is marked as changed for every merge operation.

Steps to Reproduce (for bugs)

  1. Duplicate a database
  2. Merge the 2 duplicated databases
  3. The destination database is marked as modified even though no changes were made.
@louib
Copy link
Member Author

louib commented Nov 10, 2018

I feel like this should be pretty easy, now that merger.merge() returns true if the database was modified during the merge operation!

@AlexJoss
Copy link
Contributor

Seems to be resolved on the latest build. Tested with the gui and cli, and the target database is not marked as modified. No failed tests in either testmerge or testmodified, but I was thinking that since the cli passes a message when the database is not modified after a merge operation, maybe the gui should as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants