Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for triggering Global Auto-Type #1265

Merged
merged 2 commits into from
Oct 11, 2021
Merged

Support for triggering Global Auto-Type #1265

merged 2 commits into from
Oct 11, 2021

Conversation

varjolintu
Copy link
Member

@varjolintu varjolintu commented Mar 13, 2021 •
edited
Loading

Support for triggering Global Auto-Type from KeePassXC with a separate keyboard shortcut.

Related PR: keepassxreboot/keepassxc#6272

Fixes #1191.

@varjolintu varjolintu added this to the 1.7.7 milestone Mar 13, 2021
@varjolintu varjolintu requested a review from droidmonkey March 13, 2021 09:18
@varjolintu varjolintu mentioned this pull request Mar 13, 2021
Merged
@droidmonkey
Copy link
Member

droidmonkey commented Mar 14, 2021 •
edited
Loading

Can we also add this as a button in the extension pop out view and right click menu? This works so good it needs to be a first class feature.

image

@varjolintu
Copy link
Member Author

@droidmonkey Sure. However clicking the extension icon brings the focus out of the selected input field. We need to make the focus is set back before triggering Auto-Type.

@droidmonkey
Copy link
Member

Oh good point, maybe just the right click menu than.

@varjolintu
Copy link
Member Author

@droidmonkey Context menu added. Anything more that is needed?

@droidmonkey
Copy link
Member

Is it not possible to strip down to just the base domain from the extension side? I'd prefer to not deal with all that on the kpxc side, it also adds a bunch of assumptions that the desired search is a domain to begin with.

droidmonkey
droidmonkey requested changes Mar 19, 2021
View reviewed changes
keepassxc-browser/background/event.js Outdated Show resolved Hide resolved
keepassxc-browser/background/init.js Outdated Show resolved Hide resolved
keepassxc-browser/background/init.js Outdated Show resolved Hide resolved
keepassxc-browser/background/keepass.js Outdated Show resolved Hide resolved
keepassxc-browser/background/keepass.js Outdated Show resolved Hide resolved
keepassxc-browser/background/keepass.js Outdated Show resolved Hide resolved
@varjolintu
Copy link
Member Author

@droidmonkey I also prefer doing the base domain check in the extension side. Makes the KeePassXC side implementation very simple. I'll make the changes.

@varjolintu
Copy link
Member Author

@droidmonkey Fixes made to both extension and KeePassXC side.

@varjolintu varjolintu removed this from the 1.7.7 milestone Mar 27, 2021
@varjolintu
Copy link
Member Author

Milestone removed. Let's wait for KeePassXC 2.7.0 until we merge this one.

@varjolintu varjolintu force-pushed the feature/autotype_from_browser branch from 7ffb1d4 to ea84842 Compare October 10, 2021 11:52
droidmonkey
droidmonkey requested changes Oct 10, 2021
View reviewed changes
keepassxc-browser/common/global.js Outdated Show resolved Hide resolved
keepassxc-browser/common/global.js Show resolved Hide resolved
@varjolintu varjolintu merged commit 1579838 into develop Oct 11, 2021
@varjolintu varjolintu deleted the feature/autotype_from_browser branch October 11, 2021 12:56
@varjolintu varjolintu added this to the 1.7.10 milestone Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droidmonkey droidmonkey droidmonkey approved these changes

Assignees
No one assigned
Labels
new feature
Projects
None yet
Milestone
1.7.10
Development

Successfully merging this pull request may close these issues.

Ability to trigger Auto-Type from extension
2 participants
@varjolintu @droidmonkey