-
-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vivaldi on Windows using NativeMessagingHosts of Google Chrome #48
Comments
Thank you for the info. We'll need to confirm if this is really true. |
That's odd. KeePassXC Browser is working perfectly in my Vivaldi |
@Stephan-P Could it be that you have additionally Google Chrome installed and therefore activated the Chrome integration in KeePassXC? |
Yes, I have Chrome installed alongside Vivaldi, but the KeePassXC Browser extension is ONLY installed in Vivaldi. I couldn't tell if this would activate things the way you describe. Maybe KeePassHttp has to do with it. I did have the KeePassHttp extension installed in Vivaldi, but with the new version 2.3 of KeePassXC I first disabled it and two days later removed it altogether. |
Would you mind checking your Registry, where your NativeMessagingHost entry resides? Both directories ar listed in the original issue report. And are you on stable, beta or snapshot of Vivaldi? |
Intereseting, but this explains why you can use the plugin even if only Vivaldi is enabled in KeePassXC. |
@LittleHuba Question in return: Hunch: (I leave it to others to uninstall Chrome and prove/deny the case) |
I do not have Chrome installed, therefore I did not activate Chrome in KeePassXC. When you activated both integrations for Vivaldi and Chrome in KeePassXC, it is no wonder, that the NativeMessagingHost (NMH) for Chrome is installed. Vivaldi will just use this NMH along with Chrome and the one in the registry folder of Vivaldi is ignored (e.g. never seen) |
I'm aware of this issue and I'd like to fix this for 2.3.4 but I'm still uncertain how to make the fix because it only affects Windows. |
Suggestion: |
Vivaldi is using the messaging hosts declared in registry directory of Google Chrome. Therefore selecting Vivaldi in the settings of KeePassXC will fail to enable the plugin.
Expected Behavior
Activating browser integration for Vivaldi in the settings of KeePassXC sets the NativeMessagingHost for Vivaldi and the extension can connect to the browser.
Current Behavior
The NativeMessagingHost ist set in a directory of the registry that is never queried, therefore no NativeMessagingHost is registered. The extension does say so when being debugged.
Possible Solution
Just do the same for Vivaldi on Windows as you are doing when activating browser support for Google Chrome, e.g. create the NativeMessagingHost not in "\HKCU\Software\Vivaldi\NativeMessagingHosts\org.keepassxc.keepassxc_browser" but in "\HKCU\Software\Google\Chrome\NativeMessagingHosts\org.keepassxc.keepassxc_browser"
Steps to Reproduce (for bugs)
Debug info
General Info
KeePassXC fork - 2.3.0
keepassxc-browser - 1.0.1
Operating system: Win10
Browser: Vivaldi
Proxy used: YES (but obviously the same with no proxy)
The text was updated successfully, but these errors were encountered: