Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KeepassXC-Browser no longer detecting credential fields or auto filling #300

Closed
jamz216 opened this issue Sep 13, 2018 · 11 comments
Closed

Comments

@jamz216
Copy link

jamz216 commented Sep 13, 2018

Expected Behavior

A site saved in my KeepassXC loads and the username/password are auto-filled by KeepassXC-Browser.

Current Behavior

I was having trouble with some but not all sites last week but I have since downloaded a new copy of my database, there has been an updated to chrome, and I had to clear cache/cookies for an unrelated reason and now KeepassXC-Browser will not detect/fill in the login in for for any site. I've tried opening the site from within the database (with Cmd + U) and loading the site separately. I have tried hitting "re-detect credential fields" and have tried "choose custom fields for this page".

Debug info

KeePassXC - Version 2.3.4
Revision: 6fe821c

Libraries:

  • Qt 5.9.3
  • libgcrypt 1.8.2

Operating system: macOS High Sierra (10.13)
CPU architecture: x86_64
Kernel: darwin 17.7.0

Enabled extensions:

  • Auto-Type
  • Browser Integration
  • Legacy Browser Integration (KeePassHTTP)
  • SSH Agent
  • YubiKey

KeePassXC-Browser Version: 1.2.0
Operating system: Mac
Browser: Chrome

Thank you

@varjolintu varjolintu added the bug label Sep 14, 2018
@varjolintu
Copy link
Member

What's the Chrome version you are using? Can you open the Inspector via right mouse click (and select Inspect) and see if the console has any error messages when you browse to a page and try the fill?

@whisdol
Copy link

whisdol commented Sep 14, 2018

I had the same issue in Chrome and Firefox (Nightly) on macOS and Windows 10 recently and was unable to completely pin-point it to single cause. Things I tried that eventually got it working again:

  • Remove all sites from the site preferences tab.
  • Ensure "Automatically retrieve credentials." is checked.

@varjolintu
Copy link
Member

That actually might be the cause. If there's a site in Site Preferences without the last / in the URL, content scripts might not work at all. It's already fixed in the next release. But please make sure every URL that is just a plain hostname, e.g. https://google.com/ has the last slash.

@apiraino
Copy link

I'm confirming that I've recently noted this strange behaviour (regression?) too. I can report - out of the top of my head - the following sites not working anymore:

  • Google accounts (no form autofill, no multiple credentials choose)
  • Paypal (no form autofill)
  • Amazon (no form autofill)

Note: I have the gut feeling (take it with a grain of salt) that the browser extension has become more picky about http/https URLs written in KeepassXC password entry (i.e. the extension does not detect a login for https://www.site.com if in KeepassXC the URL is http://www.site.com)

I'm using FF 63b4 and Chromium 69.0.3497.81

KeepassXC + browser ext. info:

KeePassXC - Version 2.3.4
Revision: 6fe821c

Libraries:

  • Qt 5.9.5
  • libgcrypt 1.8.1

Operating system: Ubuntu 18.04.1 LTS
CPU architecture: x86_64
Kernel: linux 4.15.0-33-generic

Enabled extensions:

  • Auto-Type
  • Browser Integration
  • Legacy Browser Integration (KeePassHTTP)
  • SSH Agent
  • YubiKey

@varjolintu
Copy link
Member

In KeePassXC 2.3.4 the title matching was removed (keepassxreboot/keepassxc#2055) which broke the subdomain matching (if it ever worked because it relied to titles, PR: keepassxreboot/keepassxc#2253). And also the scheme matching was not working correctly (keepassxreboot/keepassxc#2232). The next KeePassXC release will fix the most of these problems.

The only workaround is to use exact URL's with identical schemes.

In short, the browser extension is not more picky, KeePassXC is. The matching was way too loose in the previous versions.

@apiraino
Copy link

thanks @varjolintu for the explaination, much appreciated.

Looking forward for the new release, then 👍

@jamz216
Copy link
Author

jamz216 commented Sep 14, 2018

What's the Chrome version you are using? Can you open the Inspector via right mouse click (and select Inspect) and see if the console has any error messages when you browse to a page and try the fill?

I went to zappos.com and this message was displayed as an error message (for a different page that I have been to)
Uncaught (in promise) TypeError: https://www.fpntc.org is not a valid MatchPattern
at matchPatternToRegExp (global.js:48)
at siteMatch (global.js:91)
at browser.runtime.sendMessage.then (keepassxc-browser.js:1431)

(Note I see now that fpntc is the only site in the site preference tab, so I've now removed it).
I will also give the other suggested solutions a try and report back, thank you everyone!

@varjolintu
Copy link
Member

varjolintu commented Sep 14, 2018

@jamz216 Then this comment is the solution for your problem.

@jamz216
Copy link
Author

jamz216 commented Sep 14, 2018

I will report back in a few days when I have a chance to see which sites aren't working, thank you!

@jamz216
Copy link
Author

jamz216 commented Sep 14, 2018

Was still not working but I've just been going in to the keepass database now and adding https:// to every website that doesn't work and that seems to have fixed the issue. Hopefully this will be fixed in the next release to work as it did before. Thanks everyone for the help!

@jamz216 jamz216 closed this as completed Sep 14, 2018
@Gunni
Copy link

Gunni commented Sep 19, 2018

I had this problem too, and there were two domains in extension settings under site preferences. Neither ended in a / and when removed the extension started working again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants