Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Hide password icon #2456

Open
lonix1 opened this issue Feb 9, 2025 · 8 comments
Open

[Feature] Hide password icon #2456

lonix1 opened this issue Feb 9, 2025 · 8 comments

Comments

@lonix1
Copy link

lonix1 commented Feb 9, 2025

Very often the password button is superimposed on a password field's "reveal" button (the one that looks like an eye, which when clicked, shows the password as text rather than dots).

In such cases one cannot use the reveal button.

Please allow us to temporarily hide the password button somehow.

(I'm unsure how; perhaps if the mouse is over the password button and "shift" is depressed, then the button is hidden. Is it possible in JS to detect that a control key is pressed on its own?)

@RobBednark
Copy link

I've been encountering this a fair amount as well (maybe several times per week).

Workaround: in the browser's developer tools (e.g., inspect element), change the password's <input> element's type property from password to anything else, or remove it altogether. Here's a GIF showing how (alas, I did it on a page where there were no "eye" and "key" icons):

Image

@lonix1
Copy link
Author

lonix1 commented Feb 18, 2025

Yes I often resort to such hacks too. What I typically do is remove KP's password button from the DOM.

Really frustrating, but glad I'm not the only one! 😆

@rondie
Copy link

rondie commented Feb 24, 2025

I would propose to be able to set an offset (from the right) for the icon. I'm in the situation where I have multiple password manager plugins, which use the same location for the icon. Having an offset could show the icon next to another.

@varjolintu
Copy link
Member

We already support setting an offset with the icon. It's not configurable by user, but we use a predefined list for those pages.

@rondie
Copy link

rondie commented Feb 24, 2025

Being able to add to that list sounds like a viable solution instead of hiding the icon.

Where is it set right now? (even though I probably can't change it)

@varjolintu
Copy link
Member

@rondie We do it here: https://github.com/keepassxreboot/keepassxc-browser/blob/develop/keepassxc-browser/common/sites.js#L236
So it's not a big thing to add a new site to the list, but you'll have to wait for the next release.

@lonix1
Copy link
Author

lonix1 commented Feb 24, 2025

An offset just replaces one problem with another. And who decides what the offset should be? And if some arbitrary pixel value is chosen and it's no good, users will complain that it overlaps something else. So the solution would be to let users define it. And then the user would need to define it for all sites! And so the problem continues...

Conclusion: an offset is nice, but hiding the icon is better. And if both approaches are available, even better.

@varjolintu
Copy link
Member

@lonix1 I'm all in for having a way to hide the icon :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants