Skip to content
This repository has been archived by the owner on Aug 2, 2024. It is now read-only.

dev: Upgrade Madara JSON-RPC specs to v0.6.0-rc5 #1291

Closed
18 of 40 tasks
antiyro opened this issue Dec 4, 2023 · 5 comments
Closed
18 of 40 tasks

dev: Upgrade Madara JSON-RPC specs to v0.6.0-rc5 #1291

antiyro opened this issue Dec 4, 2023 · 5 comments
Labels
enhancement New feature or request needed-for-mainnet

Comments

@antiyro
Copy link
Contributor

antiyro commented Dec 4, 2023

Upgrade Madara JSON-RPC specs to v0.6.0-rc5

Overview

This issue concerns the implementation of the latest version of Starknet's JSON-RPC API: v0.6.0-rc5 within Madara (currently on v0.4.0) to ensure and maintain full compatibility with Starknet.

Detailed Description

Since version 0.4.0 of Starknet RPC, here's what has changed:

v0.5.1 New Features

  • General Improvements: Focused on covering information gaps between the feeder-gateway and the RPC.
  • Extracted broadcasted declare txn: Separated from declare txn.
  • Schema Enhancements: Fixed references and added "required" to write-API results.
  • Pending Block Schema Fixes: Adjustments for pending block & block with hash.
  • Broadcasted Transaction: Reintroduced with query version capability.
  • Receipts & Block Header Fields:
    • Introduced starknet_specVersion endpoint.
    • Added type field to transaction trace objects.
    • Added order field to events/messages in transaction trace.
    • Added l1_gas_price and starknet_version to block header.
    • Split transaction receipt objects by type with execution_resources.
  • Trace Improvement: Added state diffs and order to events/messages.
  • CONTRACT_ERROR Enhancement: Included string data.
  • Transaction Status API: Added starknet_getTransactionStatus and removed starknet_pendingTransactions.
  • PENDING_STATE_UPDATE Schema Fix: Addressed schema issues.
  • broadcasted_declare_txn_v1 Fields: Added missing fields.
  • Error Type Change: Modified traceBlockTransaction error type.
  • Pending Block Header: Added missing fields.

v0.6.0 New Features

  • v0.6.0-rc5:
    • Imported BROADCASTED_DECLARE_TXN in write API.
    • Added string data to VALIDATION_FAILURE.
  • v0.6.0-rc4:
    • Typo fix and property addition to schema object.
    • Mandatory simulation flags in starknet_estimateFee.
  • v0.6.0-rc3:
    • Refactored traceTransactions and estimateFee.
    • Renamed STRK to FRI.
    • Introduced TRANSACTION_EXECUTION_ERROR.
    • Added SKIP_VALIDATE flag to starknet_estimateFee.
    • Included units in FEE_ESTIMATE.
  • v0.6.0-rc2:
    • Stricter restrictions on v3 fields.
    • Fixed DECLARE_TXN_V1 version.
    • Made trace fields optional (as in 0.5.1).
  • v0.6.0-rc1:
    • Added v3 transactions additional fields.
    • Bound numeric properties by FELT and made built-in resources optional.
    • Added segment arena built-in.
  • v0.6.0-rc0:
    • Changed execution resource counters to integers.
    • Fixed schema in PENDING_DEPLOY_TXN_RECEIPT.
    • Allowed EMITTED_EVENT in pending block.
    • Disallowed certain fields in PENDING_BLOCK_HEADER.
    • Introduced v3 transactions.
    • Added state_diff to L1_HANDLER and DELEGATE call type.
    • Added resources to internal calls in a trace.

Goals/Objectives

To implement all the new features of the latest version as well as to reference here any potential problems and changes to track the status of the implementation.

Potential Challenges/Risks

Track potential risks or problems of the implementation: TBD.

Testing

Update and set up tests for the implementation: TBD.

Timeline

I expect the implementation to take around one week: TBD.

@antiyro
Copy link
Contributor Author

antiyro commented Dec 7, 2023

This issue will be solved gradually starting with a v0.5.1 (last stable) full upgrade. Please reffer to the v0.5.1 release.

@antiyro
Copy link
Contributor Author

antiyro commented Jan 6, 2024

Now that #1313 is about to be merged to implement v0.5.1 and v0.6.0 has been released here: https://github.com/starkware-libs/starknet-specs/releases. We can continue on another issue. I'll comment it under here and close it when v0.5.1 is merged.

Copy link

github-actions bot commented Feb 6, 2024

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.
Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a 👍
Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

@github-actions github-actions bot added the stale label Feb 6, 2024
@hhamud
Copy link
Contributor

hhamud commented Feb 27, 2024

I can help by grabbing this issue

Imported BROADCASTED_DECLARE_TXN in write API.

@apoorvsadana
Copy link
Collaborator

0.6.0 being tracked #1352

@github-actions github-actions bot locked and limited conversation to collaborators Apr 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request needed-for-mainnet
Projects
None yet
Development

No branches or pull requests

3 participants