serializeForm breaks form when submit is named

[tcz]

The submit input and submit button are special inputs with the following property:

Upon submitting, the data name/value pair gets sent to the server.

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/submit

This gets completely ignored by Keen when capturing form-submit events and it breaks forms that rely on this.

[amenk]

@tcz Did you try fixing this?

[tcz]

No, I did not. I think the company should fix this.

[amenk]

Root cause seems in https://github.com/defunctzombie/form-serialize/ which this uses "a modified 0.7.1"

keen-tracking.js/lib/utils/serializeForm.js

Line 2 in a3823d3

This is a modified copy of https://github.com/defunctzombie/form-serialize/ v0.7.1

of

So this seems to be that issue: defunctzombie/form-serialize#52

[amenk]

We found out that deleting the else branch here fully, at least does not break the original form submit:

keen-tracking.js/lib/utils/listener.js

Line 256 in a3823d3

else {