v2 ScaledJob can't be deployed on k8s 1.18

[zroubalik]

Validation changes were introduced in k8s 1.18: https://kubernetes.io/docs/setup/release/notes/#other-api-changes

Our ScaledJob CRD uses k8s.io/api/batch/v1/JobSpec which results in a CRD that is not possible to deploy on k8s 1.18:

kubectl apply -f deploy/crds/keda.sh_scaledjobs_crd.yaml                                                                                    ✔ 
The CustomResourceDefinition "scaledjobs.keda.sh" is invalid: 
* spec.validation.openAPIV3Schema.properties[spec].properties[jobTargetRef].properties[template].properties[spec].properties[containers].items.properties[ports].items.properties[protocol].default: Required value: this property is in x-kubernetes-list-map-keys, so it must have a default or be a required property
* spec.validation.openAPIV3Schema.properties[spec].properties[jobTargetRef].properties[template].properties[spec].properties[initContainers].items.properties[ports].items.properties[protocol].default: Required value: this property is in x-kubernetes-list-map-keys, so it must have a default or be a required property

As a workaround we need to manually mark protocol property as reguired in the generated CRD (on a 3 places), after every CRD generation.

We need to wait till this issue is solved: operator-framework/operator-sdk#3235

[zroubalik]

This patch solves this issue https://github.com/kedacore/keda/blob/00f663426e46fae64bcad8d4d9cd05b4c5ab3e8c/config/crd/patches/scaledjob_patch.yaml

Once this issue is solved upstream (in operator-sdk) we can remove the patch.

[rajatvig]

Could the patch file be merged in with the CRD? I am trying to deploy keda using Jsonnet and need a static location for the CRD to apply and I cannot use helm or kustomise.

[zroubalik]

@rajatvig you can consume installation resources from yaml file. You can find them in the releases https://github.com/kedacore/keda/releases