Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(prometheus-scaler): AWS signv4 parses region if provided #5421

Merged
merged 6 commits into from
Jan 20, 2024

Conversation

sguruvar
Copy link
Contributor

@sguruvar sguruvar commented Jan 20, 2024

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #5419

@sguruvar sguruvar requested a review from a team as a code owner January 20, 2024 18:43
@JorTurFer
Copy link
Member

JorTurFer commented Jan 20, 2024

/run-e2e aws
Update: You can check the progress here

@JorTurFer JorTurFer changed the title Fix for bug https://github.com/kedacore/keda/issues/5419 fix: Prometheus Scaler parses AWS Region if provided Jan 20, 2024
@JorTurFer JorTurFer changed the title fix: Prometheus Scaler parses AWS Region if provided fix(prometheus-scaler): AWS signv4 parses region if provided Jan 20, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
pkg/scalers/aws/aws_sigv4.go Outdated Show resolved Hide resolved
Signed-off-by: Jorge Turrado Ferrero <[email protected]>
@JorTurFer
Copy link
Member

JorTurFer commented Jan 20, 2024

/run-e2e aws
Update: You can check the progress here

@JorTurFer JorTurFer enabled auto-merge (squash) January 20, 2024 19:26
@JorTurFer
Copy link
Member

JorTurFer commented Jan 20, 2024

/run-e2e aws
Update: You can check the progress here

@JorTurFer JorTurFer enabled auto-merge (squash) January 20, 2024 19:57
@JorTurFer JorTurFer merged commit a815f06 into kedacore:main Jan 20, 2024
19 checks passed
@JorTurFer JorTurFer mentioned this pull request Feb 13, 2024
21 tasks
JorTurFer added a commit to JorTurFer/keda that referenced this pull request Feb 29, 2024
…e#5421)

Signed-off-by: Siva Guruvareddiar <[email protected]>
Co-authored-by: Jorge Turrado Ferrero <[email protected]>
@JorTurFer JorTurFer mentioned this pull request Feb 29, 2024
5 tasks
JorTurFer added a commit to JorTurFer/keda that referenced this pull request Feb 29, 2024
…e#5421)

Signed-off-by: Siva Guruvareddiar <[email protected]>
Co-authored-by: Jorge Turrado Ferrero <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
JorTurFer added a commit that referenced this pull request Feb 29, 2024
* fix(gcp scalers): Restore previous time horizon to fix missing metrics and properly close the connecctions (#5452)

* fix(gcp scalers): Restore previous time horizon to fix missing metrics

Signed-off-by: Jorge Turrado <[email protected]>

* Close gcp client on scaler closing

Signed-off-by: Jorge Turrado <[email protected]>

* fix style

Signed-off-by: Jorge Turrado <[email protected]>

---------

Signed-off-by: Jorge Turrado <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>

* fix(prometheus-scaler): AWS signv4 parses region if provided (#5421)

Signed-off-by: Siva Guruvareddiar <[email protected]>
Co-authored-by: Jorge Turrado Ferrero <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>

* Fixed the issue#5484 with inaccurate version label in release asset (#5518)

Signed-off-by: Vinod Kumar Nair <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>

* fix: Place the changelog entry in unreleased section (#5519)

Signed-off-by: Jorge Turrado <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>

* prepare changelog

Signed-off-by: Jorge Turrado <[email protected]>

---------

Signed-off-by: Jorge Turrado <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
Signed-off-by: Siva Guruvareddiar <[email protected]>
Signed-off-by: Vinod Kumar Nair <[email protected]>
Co-authored-by: Siva Guruvareddiar <[email protected]>
Co-authored-by: Vinod Kumar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prometheus AMP scaler returning error : "Credential should be scoped to a valid region."
3 participants