Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scale from zero when minReplicaCount is > 0 #524

Merged
merged 1 commit into from
Jan 6, 2020
Merged

scale from zero when minReplicaCount is > 0 #524

merged 1 commit into from
Jan 6, 2020

Conversation

zroubalik
Copy link
Member

Fixes #523

@anirudhgarg
Copy link
Contributor

LGTM. Minor shouldnt we log if there is an error as well.

@zroubalik
Copy link
Member Author

LGTM. Minor shouldnt we log if there is an error as well.

Do you mean error on updating the Deployment? Error is logged already in the method:

keda/pkg/handler/scale_deployments.go

Line 58 in d42e01b

h.logger.Error(err, "Error updating deployment", "Deployment.Namespace", deployment.GetNamespace(), "Deployment.Name", deployment.GetName())

@ahmelsayed
Copy link
Contributor

LGTM. Thanks @zroubalik

@ahmelsayed ahmelsayed merged commit 8658859 into kedacore:master Jan 6, 2020
@3d0it 3d0it mentioned this pull request Jul 3, 2020
Closed
@zroubalik zroubalik deleted the minReplicas branch August 11, 2020 11:32
preflightsiren pushed a commit to preflightsiren/keda that referenced this pull request Nov 7, 2021
@bpinske
Graphite scaler docs (kedacore#524)
fe5f86e 
Signed-off-by: Brandon Pinske <[email protected]>
Co-authored-by: Brandon Pinske <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmelsayed ahmelsayed ahmelsayed approved these changes

@Aarthisk Aarthisk Awaiting requested review from Aarthisk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

keda should scale from zero when minReplicaCount is set
3 participants
@zroubalik @anirudhgarg @ahmelsayed