-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub Runner Scaler - RateLimit Bug for GitHub Enterprise #4784
Comments
Hello, |
You're correct, the error should be pinged on 403, not 200s. Want me to patch it? |
If you can it'd be nice, if you can't, I'll do it :) |
This is a nice addition to the hotfix release that we are preparing :) |
PR submitted |
Report
When you use the
github_runner_scaler
for GitHub Enterprise with your own GitHub Appliance, you encounter an issue. The scaler fails and shows a GitHub REST API error, even though the response code of 200 means the request was successful. The problem seems to be on line 525 ofgithub_runner_scaler.go
where it tries to fetch the "X-RateLimit-Remaining" response header. However, this header is missing in responses from the GitHub Enterprise Appliance.Error Message:
Relevant code (Line 525 -527):
Expected Behavior
"When you use the
github_runner_scaler
with your owngithubAPIURL
, the code shouldn't try to fetch the "X-RateLimit-Remaining" response header."Actual Behavior
The code tries to fetch the "X-RateLimit-Remaining" response header and throws an error, since the header is missing in responses from the GitHub Enterprise Appliance. This is a false error.
Steps to Reproduce the Problem
Logs from KEDA operator
KEDA Version
None
Kubernetes Version
None
Platform
Microsoft Azure
Scaler Details
Github Runner Scaler
Anything else?
No response
The text was updated successfully, but these errors were encountered: