Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Odd number of arguments passed as key-value pairs for logging #4368

Closed
zroubalik opened this issue Mar 14, 2023 · 0 comments · Fixed by #4369
Closed

Odd number of arguments passed as key-value pairs for logging #4368

zroubalik opened this issue Mar 14, 2023 · 0 comments · Fixed by #4369
Assignees
Labels
bug Something isn't working

Comments

@zroubalik
Copy link
Member

zroubalik commented Mar 14, 2023

Report

If deprecated metricName is specified in the trigger config, the proper Deprecation message is not printed because it contains an odd number of arguments passed as key-value pairs for logging.

See this Slack thread for details: https://kubernetes.slack.com/archives/CKZJ36A5D/p1678795830230389

Workaround

Remove deprecated metricName from the trigger config.

Expected Behavior

print proper deprecation message

Actual Behavior

error

Steps to Reproduce the Problem

  1. deploy SO with metricName

Logs from KEDA operator

2023-03-14T12:02:29Z    DPANIC  odd number of arguments passed as key-value pairs for logging   {"ignored key": "prometheus"}
github.com/kedacore/keda/v2/controllers/keda.(*ScaledObjectReconciler).checkTriggers
        /workspace/controllers/keda/scaledobject_controller.go:358
github.com/kedacore/keda/v2/controllers/keda.(*ScaledObjectReconciler).reconcileScaledObject
        /workspace/controllers/keda/scaledobject_controller.go:223
github.com/kedacore/keda/v2/controllers/keda.(*ScaledObjectReconciler).Reconcile
        /workspace/controllers/keda/scaledobject_controller.go:175
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile
        /workspace/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:122
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
        /workspace/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:323
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
        /workspace/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:274
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
        /workspace/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:235

KEDA Version

2.10.0

Relates: #4220

@zroubalik zroubalik added the bug Something isn't working label Mar 14, 2023
@zroubalik zroubalik self-assigned this Mar 14, 2023
@zroubalik zroubalik moved this from To Triage to In Progress in Roadmap - KEDA Core Mar 14, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Ready To Ship in Roadmap - KEDA Core Mar 14, 2023
@tomkerkhove tomkerkhove mentioned this issue Mar 15, 2023
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant