Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS Cloudwatch Scaler: Don't require metricName and namespace when using expression #4334

Closed
JorTurFer opened this issue Mar 8, 2023 · 0 comments · Fixed by #4331
Closed

AWS Cloudwatch Scaler: Don't require metricName and namespace when using expression #4334

JorTurFer opened this issue Mar 8, 2023 · 0 comments · Fixed by #4331
Assignees
@JorTurFer
Labels
feature-request All issues for new features that have not been committed to needs-discussion

Comments

@JorTurFer
Copy link
Member

JorTurFer commented Mar 8, 2023 •
edited
Loading

Proposal

When we use expression in cloudwatch scalers, metricName and namespace aren't needed by the upstream, but we require them in the trigger parsing.
We should remove this requirement

Use-Case

No response

Is this a feature you are interested in implementing yourself?

Yes

Anything else?

No response
@JorTurFer JorTurFer added needs-discussion feature-request All issues for new features that have not been committed to labels Mar 8, 2023
@JorTurFer JorTurFer mentioned this issue Mar 8, 2023
Merged
3 tasks
@JorTurFer JorTurFer changed the title AWS Cloudwatch Scaler: Don't requiremetricName andnamespace usingexpression AWS Cloudwatch Scaler: Don't require metricName and namespace usingexpression Mar 8, 2023
@JorTurFer JorTurFer self-assigned this Mar 8, 2023
@JorTurFer JorTurFer changed the title AWS Cloudwatch Scaler: Don't require metricName and namespace usingexpression AWS Cloudwatch Scaler: Don't require metricName and namespace when usingexpression` Mar 8, 2023
@JorTurFer JorTurFer changed the title AWS Cloudwatch Scaler: Don't require metricName and namespace when usingexpression` AWS Cloudwatch Scaler: Don't require metricName and namespace when using expression Mar 8, 2023
@github-project-automation github-project-automation bot moved this from To Triage to Ready To Ship in Roadmap - KEDA Core Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JorTurFer JorTurFer

Labels
feature-request All issues for new features that have not been committed to needs-discussion
Projects
Roadmap - KEDA Core
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(aws-cloudwatch): Not require uneeded fields JorTurFer/keda
1 participant
@JorTurFer