Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Solr Scaler for KEDA #4234

Closed
ithesadson opened this issue Feb 13, 2023 · 6 comments
Closed

Adding Solr Scaler for KEDA #4234

ithesadson opened this issue Feb 13, 2023 · 6 comments
Assignees
Labels
needs-discussion scaler stale All issues that are marked as stale due to inactivity

Comments

@ithesadson
Copy link
Contributor

Proposal

I'd like to contribute to KEDA by adding a scaler for Solr.

Scaler Source

Solr

Scaling Mechanics

Scale based on query from Solr

Authentication Source

Authentication in the form of username and password

Anything else?

I'd like to create a Solr scaler. I would like to mention what i did before i started creating this scaler:

  1. I submitted ad pr fixin a bug in another scaler and it was accepted. (cassandra_scaler)
  2. I created a weather scaler to understand how a scaler is created and works.

I am thinking of using this library when creating the scaler: ( https://pkg.go.dev/github.com/vanng822/go-solr/solr)
Is there any problem if i use this library. (last updated 2020)

@tomkerkhove
Copy link
Member

The last update of the package is a concern though; are there no other Go packages dor this?

@zroubalik
Copy link
Member

The last update of the package is a concern though; are there no other Go packages dor this?

I share this concern. Or is there any other way how to communicate with Solr? Some Rest API?

@tomkerkhove tomkerkhove moved this from Proposed to To Triage in Roadmap - KEDA Core Feb 16, 2023
@ithesadson
Copy link
Contributor Author

The last update of the package is a concern though; are there no other Go packages dor this?

I share this concern. Or is there any other way how to communicate with Solr? Some Rest API?

I checked again and I can do it with Rest API. Can you assign me to this?

@tomkerkhove
Copy link
Member

Certainly - Good alternative!

@JorTurFer JorTurFer moved this from To Triage to To Do in Roadmap - KEDA Core Mar 13, 2023
@JorTurFer JorTurFer moved this from To Do to In Progress in Roadmap - KEDA Core Mar 13, 2023
@stale
Copy link

stale bot commented Apr 19, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale All issues that are marked as stale due to inactivity label Apr 19, 2023
@stale
Copy link

stale bot commented Apr 26, 2023

This issue has been automatically closed due to inactivity.

@stale stale bot closed this as completed Apr 26, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Ready To Ship in Roadmap - KEDA Core Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-discussion scaler stale All issues that are marked as stale due to inactivity
Projects
Archived in project
Development

No branches or pull requests

3 participants