Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metricName shouldn't be required and should be deprecated for Graphite Scaler #4229

Closed
JorTurFer opened this issue Feb 12, 2023 · 1 comment
Closed

metricName shouldn't be required and should be deprecated for Graphite Scaler #4229

JorTurFer opened this issue Feb 12, 2023 · 1 comment
Labels
good first issue Good for newcomers help wanted Looking for support from community

Comments

@JorTurFer
Copy link
Member

JorTurFer commented Feb 12, 2023 •
edited
Loading

Proposal

Currently, Graphite Scaler requires a metricName which is used only for KEDA internal things (it's not sent to the prom server).
This requirement isn't necessary since we introduced mechanisms to ensure the unique metrics names inside the ScaledObject and we should make it optional and also deprecate it in favor of self-generated internal name

https://github.com/kedacore/keda/blob/main/pkg/scalers/graphite_scaler.go#L95-L99
@JorTurFer JorTurFer added help wanted Looking for support from community good first issue Good for newcomers labels Feb 12, 2023
@JorTurFer JorTurFer mentioned this issue Feb 12, 2023
Closed
5 tasks
@tomkerkhove tomkerkhove moved this from Proposed to To Triage in Roadmap - KEDA Core Feb 16, 2023
@zroubalik
Copy link
Member

will be handled by #4220

@github-project-automation github-project-automation bot moved this from To Triage to Ready To Ship in Roadmap - KEDA Core Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Looking for support from community
Projects
Roadmap - KEDA Core
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zroubalik @JorTurFer