Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate GetMetrics() and IsActive() to GetMetricsAndActivity() #4015

Closed
zroubalik opened this issue Dec 15, 2022 · 0 comments · Fixed by #4238
Closed

Consolidate GetMetrics() and IsActive() to GetMetricsAndActivity() #4015

zroubalik opened this issue Dec 15, 2022 · 0 comments · Fixed by #4238
Labels
feature-request All issues for new features that have not been committed to good first issue Good for newcomers help wanted Looking for support from community stale-bot-ignore All issues that should not be automatically closed by our stale bot

Comments

@zroubalik
Copy link
Member

Proposal

Majority of scalers migrated logic fromGetMetrics() and IsActive() methods into GetMetricsAndActivity().

There are a few oustanding scalers that haven't been migrated so far:

  • Azure Event Hub
  • Cron
  • External

Use-Case

No response

Anything else?

No response
@zroubalik zroubalik added help wanted Looking for support from community feature-request All issues for new features that have not been committed to stale-bot-ignore All issues that should not be automatically closed by our stale bot labels Dec 15, 2022
@tomkerkhove tomkerkhove moved this to Proposed in Roadmap - KEDA Core Dec 15, 2022
@zroubalik zroubalik mentioned this issue Dec 15, 2022
Closed
@zroubalik zroubalik moved this from Proposed to To Do in Roadmap - KEDA Core Dec 15, 2022
@JorTurFer JorTurFer added the good first issue Good for newcomers label Feb 8, 2023
@troydn troydn mentioned this issue Feb 14, 2023
Merged
3 tasks
@github-project-automation github-project-automation bot moved this from To Do to Ready To Ship in Roadmap - KEDA Core Feb 16, 2023
@JorTurFer JorTurFer moved this from Ready To Ship to Done in Roadmap - KEDA Core Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request All issues for new features that have not been committed to good first issue Good for newcomers help wanted Looking for support from community stale-bot-ignore All issues that should not be automatically closed by our stale bot
Projects
Roadmap - KEDA Core
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Consolidate GetMetrics() and IsActive() to GetMetricsAndActivity() troydn/keda
2 participants
@zroubalik @JorTurFer