Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use gophercloud in Openstack scalers instead of interacting with the REST Api #3439

Closed
JorTurFer opened this issue Jul 27, 2022 · 3 comments · Fixed by #5137
Closed

Use gophercloud in Openstack scalers instead of interacting with the REST Api #3439

JorTurFer opened this issue Jul 27, 2022 · 3 comments · Fixed by #5137
Assignees
@husnialhamdani
Labels
feature-request All issues for new features that have not been committed to good first issue Good for newcomers help wanted Looking for support from community needs-discussion stale-bot-ignore All issues that should not be automatically closed by our stale bot

Comments

@JorTurFer
Copy link
Member

Proposal

Right now, we have our own code to interact with openstack instead of using any native SDK. https://github.com/gophercloud/gophercloud is a native Golang SDK for Openstack that we are already using for e2e tests and it seems that brings all the capabilities that we need.
Using a documented and maintained SDK is easier and better for KEDA maintainability

Use-Case

No response

Anything else?

No response
@JorTurFer JorTurFer added needs-discussion feature-request All issues for new features that have not been committed to labels Jul 27, 2022
@tomkerkhove tomkerkhove moved this to Proposed in Roadmap - KEDA Core Jul 27, 2022
@JorTurFer JorTurFer moved this from Proposed to To Do in Roadmap - KEDA Core Jul 27, 2022
@stale
Copy link

stale bot commented Sep 25, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale All issues that are marked as stale due to inactivity label Sep 25, 2022
@JorTurFer JorTurFer added the stale-bot-ignore All issues that should not be automatically closed by our stale bot label Sep 26, 2022
@stale stale bot removed the stale All issues that are marked as stale due to inactivity label Sep 26, 2022
@JorTurFer JorTurFer added help wanted Looking for support from community Hacktoberfest labels Sep 26, 2022
@JorTurFer JorTurFer added the good first issue Good for newcomers label Dec 9, 2022
@husnialhamdani
Copy link
Contributor

husnialhamdani commented Oct 2, 2023 •
edited
Loading

Hi @JorTurFer,
I interested to take this, Could you please assign to me?

@JorTurFer
Copy link
Member Author

Hey!
Sure, thanks for helping us ❤️
The main idea is to replace our self-maintained code for openstack with their supported SDK. There is a lot of code inside OpenStack scalers using the rest client directly, but it means that if there are any change in the apis, we need to address them instead of just bumping a SDK

@husnialhamdani husnialhamdani mentioned this issue Oct 30, 2023
Merged
2 tasks
@zroubalik zroubalik moved this from To Do to In Review in Roadmap - KEDA Core Nov 23, 2023
@github-project-automation github-project-automation bot moved this from In Review to Ready To Ship in Roadmap - KEDA Core Nov 23, 2023
@tomkerkhove tomkerkhove moved this from Ready To Ship to Done in Roadmap - KEDA Core Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@husnialhamdani husnialhamdani

Labels
feature-request All issues for new features that have not been committed to good first issue Good for newcomers help wanted Looking for support from community needs-discussion stale-bot-ignore All issues that should not be automatically closed by our stale bot
Projects
Roadmap - KEDA Core
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor REST API to Gophercloud SDK husnialhamdani/keda
3 participants
@tomkerkhove @husnialhamdani @JorTurFer