Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a check to validate the changelog on PRs #3190

Closed
JorTurFer opened this issue Jun 19, 2022 · 2 comments · Fixed by #4731
Closed

Add a check to validate the changelog on PRs #3190

JorTurFer opened this issue Jun 19, 2022 · 2 comments · Fixed by #4731
Assignees
@nitishchauhan0022
Labels
automation enhancement New feature or request help wanted Looking for support from community

Comments

@JorTurFer
Copy link
Member

Proposal

Even it's documented the proper way to add entries in the changelog, there are cases where we still approve PRs with the entry unsorted or with other style errors.
It's difficult to review every thing without any error, but maybe we can create a bash script that checks the unreleased section to validate it and append it to pre-commit checks

Use-Case

No response

Anything else?

No response
@JorTurFer JorTurFer added needs-discussion feature-request All issues for new features that have not been committed to labels Jun 19, 2022
@tomkerkhove tomkerkhove moved this to Proposed in Roadmap - KEDA Core Jun 19, 2022
@tomkerkhove tomkerkhove added enhancement New feature or request automation help wanted Looking for support from community and removed needs-discussion feature-request All issues for new features that have not been committed to labels Jun 20, 2022
@nitishchauhan0022
Copy link
Contributor

/assing @JorTurFer can you please share the link for

Even it's documented the proper way to add entries in the changelog

@JorTurFer
Copy link
Member Author

https://github.com/kedacore/keda/blob/main/CONTRIBUTING.md#Changelog

@nitishchauhan0022 nitishchauhan0022 mentioned this issue Jun 23, 2023
Merged
2 tasks
@github-project-automation github-project-automation bot moved this from Proposed to Ready To Ship in Roadmap - KEDA Core Aug 17, 2023
@SpiritZhou SpiritZhou mentioned this issue Aug 21, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nitishchauhan0022 nitishchauhan0022

Labels
automation enhancement New feature or request help wanted Looking for support from community
Projects
Roadmap - KEDA Core
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

adding the script to validate changelog nitishchauhan0022/keda
3 participants
@tomkerkhove @JorTurFer @nitishchauhan0022