Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Azure Data Explorer e2e tests with active directory credentials. #2841

Closed
v-shenoy opened this issue Mar 29, 2022 · 4 comments
Closed

Add Azure Data Explorer e2e tests with active directory credentials. #2841

v-shenoy opened this issue Mar 29, 2022 · 4 comments
Assignees
Labels
azure All issues concerning integration with Azure testing

Comments

@v-shenoy
Copy link
Contributor

Relates to #2770, #2882.

@v-shenoy v-shenoy self-assigned this Mar 29, 2022
@tomkerkhove tomkerkhove moved this to Proposed in Roadmap - KEDA Core Mar 29, 2022
@v-shenoy v-shenoy added azure All issues concerning integration with Azure testing labels Mar 29, 2022
@v-shenoy v-shenoy changed the title Add Azure Data Explorer tests using active directory credentials. Add Azure Data Explorer e2e tests with active directory credentials. Mar 29, 2022
@zroubalik zroubalik moved this from Proposed to To Do in Roadmap - KEDA Core Mar 29, 2022
@tomkerkhove
Copy link
Member

Make sure to check #2822 (review) as we need #2741 instead of #2882

/cc @kedacore/keda-maintainers

@v-shenoy
Copy link
Contributor Author

v-shenoy commented Apr 4, 2022

@tomkerkhove I wasn't planning on enabling the pod identity tests here. Instead of having all e2e tests disabled for Data Explorer, I was going to add a condition to disable only the ones using pod identity (as I can see there is already one using AD credentials). This ensures that we at least have some tests running for Data Explorer that we can check on PRs. The condition can then be removed once #2741 is merged.

@v-shenoy
Copy link
Contributor Author

v-shenoy commented Apr 4, 2022

Should I wait until #2741 is merged before working on this?

@tomkerkhove
Copy link
Member

@tomkerkhove I wasn't planning on enabling the pod identity tests here. Instead of having all e2e tests disabled for Data Explorer, I was going to add a condition to disable only the ones using pod identity (as I can see there is already one using AD credentials). This ensures that we at least have some tests running for Data Explorer that we can check on PRs. The condition can then be removed once #2741 is merged.

This sounds like a good plan to me!

Repository owner moved this from To Do to Ready To Ship in Roadmap - KEDA Core Apr 25, 2022
@tomkerkhove tomkerkhove moved this from Ready To Ship to Done in Roadmap - KEDA Core Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
azure All issues concerning integration with Azure testing
Projects
Archived in project
Development

No branches or pull requests

2 participants