Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent file naming in pkg/scalers/ #2806

Closed
zroubalik opened this issue Mar 23, 2022 · 0 comments · Fixed by #2807
Closed

Inconsistent file naming in pkg/scalers/ #2806

zroubalik opened this issue Mar 23, 2022 · 0 comments · Fixed by #2807
Labels
bug Something isn't working

Comments

@zroubalik
Copy link
Member

Report

All scalers and their tests should have consistent naming:
For example for scaler that operates on service foo the scaler code should live infoo_scaler.go and related test in foo_scaler_test.go.

Some scalers don't follow this (eg. aws related, huawei)

Expected Behavior

aligned naming

Actual Behavior

not aligned

Steps to Reproduce the Problem

  1. ls -al pkg/scalers

Logs from KEDA operator

No response

KEDA Version

No response

Kubernetes Version

No response

Platform

No response

Scaler Details

No response

Anything else?

No response
@zroubalik zroubalik added the bug Something isn't working label Mar 23, 2022
@tomkerkhove tomkerkhove moved this to Proposed in Roadmap - KEDA Core Mar 23, 2022
This was referenced Mar 23, 2022
Merged
Merged
Repository owner moved this from Proposed to Ready To Ship in Roadmap - KEDA Core Mar 23, 2022
@tomkerkhove tomkerkhove moved this from Ready To Ship to Done in Roadmap - KEDA Core Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Roadmap - KEDA Core
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Consistent file naming in pkg/scalers/ zroubalik/keda
1 participant
@zroubalik