Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure EventHub Scaler: don't expose connection string in metricName #2403

Closed
JorTurFer opened this issue Dec 15, 2021 · 0 comments · Fixed by #2404
Closed

Azure EventHub Scaler: don't expose connection string in metricName #2403

JorTurFer opened this issue Dec 15, 2021 · 0 comments · Fixed by #2404
Assignees
@JorTurFer
Labels
bug Something isn't working security All issues related to security

Comments

@JorTurFer
Copy link
Member

JorTurFer commented Dec 15, 2021 •
edited
Loading

Report

As a user has reported here, KEDA exposes the EventHubConnection in the metricName

Name: GenerateMetricNameWithIndex(scaler.metadata.scalerIndex, kedautil.NormalizeString(fmt.Sprintf("azure-eventhub-%s", scaler.metadata.eventHubInfo.EventHubConnection)))

Expected Behavior

KEDA shouldn't expose secrets

Scaler Details

Azure EventHub
@JorTurFer JorTurFer added the bug Something isn't working label Dec 15, 2021
@JorTurFer JorTurFer added this to the v2.6.0 milestone Dec 15, 2021
@JorTurFer JorTurFer self-assigned this Dec 15, 2021
@JorTurFer JorTurFer added the security All issues related to security label Dec 15, 2021
@JorTurFer JorTurFer mentioned this issue Dec 15, 2021
Merged
5 tasks
@JorTurFer JorTurFer removed this from the v2.6.0 milestone Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JorTurFer JorTurFer

Labels
bug Something isn't working security All issues related to security
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Azure EventHub Scaler: don't expose connection string in metricName JorTurFer/keda
1 participant
@JorTurFer