Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support to ValueMetricType using cpu_memory_scaler #2218

Merged
merged 4 commits into from
Oct 27, 2021

Conversation

JorTurFer
Copy link
Member

@JorTurFer JorTurFer commented Oct 26, 2021

Signed-off-by: jorturfer [email protected]

This PR removes the support to Value metricType in CPU and Memory scalers. HPA doesn't support that metricType in these cases, so it doesn't make sense to maintain in as part of the scaler
#2200 (comment)

Checklist

Fixes #2200

@JorTurFer JorTurFer changed the title Delete ValueMetricType from cpu_memory_scaler Delete ValueMetricType from cpu_memory_scaler Oct 26, 2021
@JorTurFer JorTurFer changed the title Delete ValueMetricType from cpu_memory_scaler Drop support to ValueMetricType using cpu_memory_scaler Oct 26, 2021
Signed-off-by: jorturfer <[email protected]>
Signed-off-by: jorturfer <[email protected]>
@zroubalik zroubalik added this to the v2.5.0 milestone Oct 27, 2021
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update the error message on L64 to something like fmt.Errorf("unsupported metric type, allowed values are 'Utilization' or 'AverageValue'")

Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
Copy link
Member Author

Could you please update the error message on L64 to something like fmt.Errorf("unsupported metric type, allowed values are 'Utilization' or 'AverageValue'")

Sure! Now it's more explicit :)

@zroubalik zroubalik merged commit 49d60dc into kedacore:main Oct 27, 2021
@JorTurFer JorTurFer deleted the remove_value_cpu_memeory branch October 27, 2021 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using 'Value' in CPU scaler results in an error (must set either a target raw value or a target utilization)
2 participants