Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KEDA HTTP Addon documentation #548

Open
2 tasks
Tracked by #221
arschles opened this issue Oct 8, 2021 · 16 comments · May be fixed by #554
Open
2 tasks
Tracked by #221

KEDA HTTP Addon documentation #548

arschles opened this issue Oct 8, 2021 · 16 comments · May be fixed by #554
Labels
cant-touch-this All issues that should not be automatically closed by our stale bot

Comments

@arschles
Copy link
Contributor

arschles commented Oct 8, 2021

The KEDA HTTP Addon project is readying to release a v0.2.0 and we already have a significant amount of documentation. Currently, it's relatively disorganized in the docs/ directory (currently experimenting with the wiki in kedacore/http-add-on#296 Edit: it's much nicer to track documentation in a single repository, so didn't do this) and it would be nice to have better docs that are in a dedicated space.

Since this project is part of the KEDA organization, it seems to make sense to either be part of the keda.sh site or at least be in the same repository. I'm impartial to those logistics, I'd mostly just like to:

  1. store documentation in a space dedicated to documentation
  2. Be able to render those documentation in a logical way

Use-Case

Write, store and render documentation in a way that's more logical to humans.

Specification

  • Move documentation here, or another place dedicated to documentation
  • Render those documentation on keda.sh, GitBook, or another place dedicated to rendering documentation in a logical way that's friendly to humans
@zroubalik
Copy link
Member

+1

Having a section on keda.sh make sense imho.

@tomkerkhove
Copy link
Member

Agreed, I'm just thinking about where. We could have it as a "scaler" but then it has to be clear that it's not one out of the box.

@zroubalik
Copy link
Member

zroubalik commented Oct 11, 2021

A separate section, something like Addons ?

@arschles
Copy link
Contributor Author

A separate section, something like Addons ?

Is there a plan to have other Addons? If not, what about a separate section for HTTP?

@tomkerkhove
Copy link
Member

We have a Cosmos DB external scaler as well but I'm not sure if we should "treat them as special" external scalers.

I think HTTP is maybe a bit more exceptional scenario here, but what I have in mind is:

Thoughts?

@arschles
Copy link
Contributor Author

@tomkerkhove that approach sounds good. Having a separate section for HTTP makes sense because there is a lot of documentation already (see wiki), with scope that goes beyond just operating a scaler alongside KEDA

@arschles
Copy link
Contributor Author

I'll submit a PR to this repository today with a prototype of what the HTTP addon documentation (not the external scaler section) might look like

@arschles arschles linked a pull request Oct 14, 2021 that will close this issue
4 tasks
@tomkerkhove tomkerkhove added this to the Documentation Improvements milestone Nov 17, 2021
@tomkerkhove
Copy link
Member

I'm adding this to our Documentation Improvements to see how we can further improve this

@arschles
Copy link
Contributor Author

Sounds good @tomkerkhove. I've closed kedacore/http-add-on#296 for now. Will keep all documentation in the docs/ repository in the HTTP Addon repository for now until you tell me otherwise. Also I'm happy to close #554 and wait if you have bigger ideas. Let me know

@tomkerkhove
Copy link
Member

Sounds like a good idea, but feel free to keep #554 open!

@tomkerkhove
Copy link
Member

This should have a seperate section on our website for external scalers that are owned by KEDA org.

@stale
Copy link

stale bot commented Feb 11, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale All issues that are marked as stale due to inactivity label Feb 11, 2022
@arschles
Copy link
Contributor Author

@tomkerkhove can you add the right label to prevent the stalebot from closing this? I think it's still pending some CNCF work, but I definitely don't want to close this issue meanwhile.

@stale stale bot removed the stale All issues that are marked as stale due to inactivity label Feb 11, 2022
@zroubalik zroubalik added the cant-touch-this All issues that should not be automatically closed by our stale bot label Feb 11, 2022
@tomkerkhove tomkerkhove removed this from the Documentation Improvements milestone Aug 1, 2022
@Rohithzr
Copy link

Rohithzr commented Feb 19, 2024

+1 for it being under keda.sh

The section Routing to the Right Service needs better explanation of the current scenario where a scalable service gets created on the "addon-namespace" and hence the ingress needs to be created on that same namespace and be pointed to keda-http-add-on-interceptor-proxy

I actually think we should not even mention "ingress-nginx" and simply say point your ingress to the service. and put the ingress-nginx part on another example somewhere.

We should also explain the scalability of the interceptor proxy and provide some stress testing results.

Happy to contribute on all points above.

@zroubalik
Copy link
Member

@Rohithzr that would be great!

@tomkerkhove
Copy link
Member

@nate-double-u @thisisobate Any thoughts when this one can be planned? It has been open for a while as part of the doc improvement effort

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cant-touch-this All issues that should not be automatically closed by our stale bot
Projects
Status: Todo
Development

Successfully merging a pull request may close this issue.

4 participants